Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[port] impstation SM adjustments #431

Merged
merged 11 commits into from
Feb 24, 2025
Merged

Conversation

corresp0nd
Copy link
Collaborator

@corresp0nd corresp0nd commented Feb 23, 2025

About the PR

primary ports are from impstation #1359, but this is honestly a little bit of a mess so there are likely going to be some edits i missed crediting. this does also include some edits from EE #1719.

one thing to note that "embedding" items into the supermatter (trying to touch it with something specific) does not work the same way it does in impstation. their code requires also porting EE's throwing system and i cannot be bothered to do that. sorry.

Why / Balance

supermatter is consistently the hardest engine to learn, not necessarily due to it being complex, but due to a lack of in game ways to properly teach its mechanics. the primary addition of this pr, the supermatter monitoring console, addresses that

Technical details

if you add a new gas you HAVE to define it in the dictionary in /Content.Shared/_EE/Supermatter/Components/SupermatterComponent.cs ... ideally, yknow, it wouldn't crash the game if you forgot. but it will crash the game if you don't define it.

Media

Screenshot 2025-02-22 183758
Screenshot 2025-02-22 183755
instead of staring at the guidebook, this will hopefully encourage players to experiment and see the different multipliers per gas.

Requirements

Breaking changes

Changelog

🆑 Darkmajia, AftrLite, VMSolidus

  • tweak: The supermatter has received a large amount of changes and upgrades. Check out the updated guidebook!
  • tweak: The supermatter monitoring console now has full functionality.
  • fix: The supermatter now emits waste gas as intended, instead of storing waste inside itself.

Copy link
Contributor

github-actions bot commented Feb 23, 2025

RSI Diff Bot; head commit 2a50148 merging into 8a93ed7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_Goobstation/Supermatter/supermatter.rsi

State Old New Status
supermatter Removed

Resources/Textures/_EE/Structures/Machines/computers.rsi

State Old New Status
computer Added
generic_keyboard Added
generic_panel_open Added
supermatter-0 Added
supermatter-1 Added
supermatter-2 Added
supermatter-3 Added
supermatter-4 Added
supermatter-5 Added
supermatter-6 Added
supermatter_keys Added

Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter.rsi

State Old New Status
supermatter-glow-delam Added
supermatter-glow-emergency Added
supermatter-glow Added
supermatter-psy Added
supermatter Added

Edit: diff updated after 2a50148

@corresp0nd
Copy link
Collaborator Author

i'm going to edit the map files tomorrow to include the new console, don't merge until i finish those please <3

@corresp0nd
Copy link
Collaborator Author

corresp0nd commented Feb 23, 2025

oh, also @lumpylemons / @marc-pelletier
i had to add nitrium to the SM dictionary or else it got very very upset, do these numbers look right or should i edit them? i just copied trit's numbers since they act sorta similarly. ish maybe idk.
Screenshot 2025-02-22 184934

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@corresp0nd
Copy link
Collaborator Author

ready 4 merge

@taydeo taydeo merged commit 966f618 into funky-station:master Feb 24, 2025
13 of 14 checks passed
taydeo pushed a commit that referenced this pull request Feb 24, 2025
@McBosserson
Copy link
Contributor

McBosserson commented Feb 25, 2025

the primary addition of this pr, the supermatter monitoring console, addresses that

This is a complete refactor.

Seems good, but it's unclear what influences the low temp healing delta? Cold trit didn't heal it.

@corresp0nd corresp0nd deleted the supermatter branch February 26, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants