-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[port] impstation SM adjustments #431
Conversation
RSI Diff Bot; head commit 2a50148 merging into 8a93ed7 Resources/Textures/_Goobstation/Supermatter/supermatter.rsi
Resources/Textures/_EE/Structures/Machines/computers.rsi
Resources/Textures/_EE/Structures/Power/Generation/Supermatter/supermatter.rsi
|
i'm going to edit the map files tomorrow to include the new console, don't merge until i finish those please <3 |
oh, also @lumpylemons / @marc-pelletier |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ready 4 merge |
This is a complete refactor. Seems good, but it's unclear what influences the low temp healing delta? Cold trit didn't heal it. |
About the PR
primary ports are from impstation #1359, but this is honestly a little bit of a mess so there are likely going to be some edits i missed crediting. this does also include some edits from EE #1719.
one thing to note that "embedding" items into the supermatter (trying to touch it with something specific) does not work the same way it does in impstation. their code requires also porting EE's throwing system and i cannot be bothered to do that. sorry.
Why / Balance
supermatter is consistently the hardest engine to learn, not necessarily due to it being complex, but due to a lack of in game ways to properly teach its mechanics. the primary addition of this pr, the supermatter monitoring console, addresses that
Technical details
if you add a new gas you HAVE to define it in the dictionary in /Content.Shared/_EE/Supermatter/Components/SupermatterComponent.cs ... ideally, yknow, it wouldn't crash the game if you forgot. but it will crash the game if you don't define it.
Media
instead of staring at the guidebook, this will hopefully encourage players to experiment and see the different multipliers per gas.
Requirements
Breaking changes
Changelog
🆑 Darkmajia, AftrLite, VMSolidus