Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further supermatter adjustments #1359

Merged
merged 44 commits into from
Jan 25, 2025

Conversation

Darkmajia
Copy link

@Darkmajia Darkmajia commented Jan 14, 2025

changes a LOT about the supermatter and the supermatter console. am i going to list it all? yes, actually, look at my todo. i'm not supplying videos or images or anything because i am fucking dying after spending however long on this

todo:

  • add attributions to the rest of the sound files
  • move distortion from popup to chat message
  • add paracusia to mobs after reality distortion
  • add paracusia to mobs that stare at the crystal without meson protection
  • anomaly spawning at low integrity
  • better-looking supermatter explosion
  • prevent supermatter (or all?) lightning from getting bounced around by explosions
  • fix up processing, primarily the dynamic heat resistance
  • add additional alerts for critical conditions (charge inertia reaction, etc)
  • fix up the supermatter console
  • comment the dang code
  • clean up the dang code
  • finish any todos
  • guidebook adjustments
  • fix up any loose prototypes in upstream yaml
  • add admin alerts and logging
  • add pulling? magboot knowledge check?
  • psychologist coefficient
  • add proper miasma scaling: probably just look through all of tg's processing to Do It Right
  • add supermatter glow while taking damage
  • fix embeddable projectile bug
  • make inserted items ash
  • keep the supermatter working while unanchored
  • convert a bunch of datafields to cvars

maybe todo:

  • supermatter shard
  • better supermatter sliver

Changelog
🆑 Darkmajia, AftrLite

  • tweak: The supermatter has received a large amount of changes and upgrades. Check out the updated guidebook!
  • tweak: The supermatter monitoring console now has full functionality.
  • fix: The supermatter now emits waste gas as intended, instead of storing waste inside itself.

Copy link

@hivehum hivehum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell on babbu technique. die babbu

@@ -101,3 +100,4 @@
sprite: Structures/Power/Generation/Singularity/singularity_6.rsi
state: singularity_6
scale: .9,.9
- type: SupermatterImmune # imp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this got moved

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i prefer keeping imp edits at the bottom of prototypes so its easier to group them up or see whats changed

<Document>
# Supermatter Engine

The supermatter engine is an incredibly dangerous, volatile, and radioactive source of power. Without proper management, the supermatter chamber will fill with fire, arcs of lightning will spark, and eventually, an explosion will destroy the entire engineering department.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Without careful management, the supermatter chamber will fill with fire, lightning will arc out, and, eventually, an explosion will obliterate Engineering."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also is supermatter a proper noun or nah

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antimatter isnt, so im leaning on no


The supermatter engine is an incredibly dangerous, volatile, and radioactive source of power. Without proper management, the supermatter chamber will fill with fire, arcs of lightning will spark, and eventually, an explosion will destroy the entire engineering department.

But with proper care and handling, the supermatter can be an incredibly potent power source for the station. A basic setup will take care of most of the power load, but the supermatter crystal is affected strongly by gases in many different ways.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second sentence feels like two entirely different concepts smooshed together.

"While a basic setup will take care of the station's typical power load, the supermatter crystal is affected strongly by gases in many different ways — both beneficial and harmful."


Before stepping into the supermatter chamber, there are a few things to keep in mind to avert disaster and personal harm.

• Do not power the crystal before the cooling loop has been set up. Do not touch the crystal. Do not walk into the crystal.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe color the second two sentences for emphasis


To harness the radioactive potential of the crystal, radiations collectors are placed nearby. These connect to HV cables, generating power for the station.

Radiations collectors require a tank full of plasma gas to operate, which will need to be replaced every so often to maintain power output.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Radiation collectors require a filled tank of plasma gas to operate, which will need to be replaced periodically to maintain power generation.


## Cooling Loop

At the most fundamental level, the supermatter crystal is kept stable with a loop of atmospheric pipes. The chamber is filled with safe, cold gas, whilst any harmful or unwanted byproducts are filtered out of the system.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would put "loop" in quotes


To set up the cooling loop, anchor the nitrogen canisters to the input connector ports and enable the respective gas pumps. Follow the pipes, enabling gas pumps and filters as you go.

Be careful not to activate the gas pumps inside the interior chamber's airlocks before the full cooling loop is set up. A bypass gas pump is located outside the external airlock: use this to keep gas flowing as you work.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colon becomes semicolon


<GuideEntityEmbed Entity="GasAnalyzer"/>

Once the full cooling loop has been set up, double check with a gas analyzer to make sure the gas is not trapped at any point in the system. Disable the bypass gas pump by the airlocks, enable the interior gas pumps, and configure the air alarm.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop "double" in first sentence


<GuideEntityEmbed Entity="Emitter"/>

Once the cooling loop is fully set up and the radiation collectors are filled, the supermatter engine is ready to be started up.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the supermatter engine is ready to start up.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe "ready to be initialized."

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i went with "start up" i hope you can forgive me

@Darkmajia Darkmajia dismissed hivehum’s stale review January 20, 2025 12:44

guidebook has been long finished. welcome to look over it again, though

@Darkmajia Darkmajia marked this pull request as ready for review January 23, 2025 19:44
@Darkmajia Darkmajia requested a review from a team January 23, 2025 20:09
@Darkmajia
Copy link
Author

i apologise to whoever reviews this. or you can merge without looking

@mqole
Copy link

mqole commented Jan 25, 2025

full disclosure im just gonna trust you on all these directories

Copy link

@mqole mqole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally i believe darkmajia has suffered more than jesus

this may need any number of tweaks in the coming days/weeks/months but this is an insane amount of work and its fucking brilliant. amazing shit dark

@mqole mqole merged commit 40b4444 into impstation:master Jan 25, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants