Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support any character in enter, leave commands (and make tests work) #65

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

frcroth
Copy link
Contributor

@frcroth frcroth commented Jun 3, 2022

Closes #42

image
is turned into
image

@frcroth frcroth requested review from jeriox and Paula-Kli June 3, 2022 10:01
Copy link
Collaborator

@Paula-Kli Paula-Kli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it that what you wanted in the issue @SilvanVerhoeven ?

@frcroth frcroth force-pushed the feature/support-dots-in-commands branch 2 times, most recently from 3387dbe to 31fc91d Compare June 3, 2022 10:54
@frcroth
Copy link
Contributor Author

frcroth commented Jun 3, 2022

OK the tests won't work. If someone is an expert on tests, they may take a look at it. Otherwise I can remove the tests so they don't cause problems. (The test works on my machine 😉).

Update 1:
The tests currently don't work because they are missing dependencies for databases (This was no problem before since no tests actually used the database). These dependencies should be installed by poetry install -E mysql -E pgsql but they are just not.

Update 2:
I'm now manually installing dependencies again, which seems to work. The remaining problem is that the setup of the mysql db does not seem to work properly.

Update 3:
Works now! Only took like 3 hours, well now everyone can write tests so I'm expecting a lot of tests

@frcroth frcroth force-pushed the feature/support-dots-in-commands branch from 31fc91d to aa06919 Compare June 3, 2022 12:40
@SilvanVerhoeven
Copy link
Collaborator

OK the tests won't work. If someone is an expert on tests, they may take a look at it. Otherwise I can remove the tests so they don't cause problems. (The test works on my machine 😉)

I don't know about those either, maybe @jeriox

@frcroth frcroth force-pushed the feature/support-dots-in-commands branch 18 times, most recently from ff350bd to bed730f Compare June 3, 2022 17:18
@frcroth frcroth force-pushed the feature/support-dots-in-commands branch from bed730f to 0c0404e Compare June 3, 2022 17:18
@frcroth frcroth requested a review from SilvanVerhoeven June 3, 2022 17:25
@frcroth frcroth changed the title Support any character in enter, leave commands Support any character in enter, leave commands (and make tests work) Jun 3, 2022
@SilvanVerhoeven
Copy link
Collaborator

Thank you so much for fixing the tests!!! :) (haven't checked whether it works for me tho)

Co-authored-by: SilvanVerhoeven <[email protected]>
@frcroth frcroth merged commit af4fd59 into fsr-de:main Jun 6, 2022
@frcroth frcroth deleted the feature/support-dots-in-commands branch June 6, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support dots in commands
4 participants