Fix ReDoS issue in minutes commands #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's unfortunate, I used to miss this function in myHPI. But no hard objection from my side, thanks for letting me know |
Pull Request Test Coverage Report for Build 4261764779
💛 - Coveralls |
|
I think we can merge this for security purposes now, and @SilvanVerhoeven can create an issue for it to create an efficient and nice regex |
jeriox
approved these changes
Feb 27, 2023
SilvanVerhoeven
pushed a commit
to SilvanVerhoeven/myHPI
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283
Reverts changes to the enter and leave commands made in #65. This no longer allows for the pattern
|enter|(12:23)(Some Person (Special Role))