Fix misc sheet issues #2593
Fix misc sheet issues #2593
Conversation
WalkthroughThis pull request introduces localization and character-specific modifications across multiple files. The changes primarily focus on enhancing character mechanics for Mavuika and Citlali, updating localization assets, and refining weapon sheet configurations. The modifications include adding new constants, updating damage calculation logic, and introducing conditional rendering based on constellation levels. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[frontend] [Thu Jan 9 23:24:39 UTC 2025] - Deployed 940fcce to https://genshin-optimizer-prs.github.io/pr/2593/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Fri Jan 10 02:20:05 UTC 2025] - Deployed 31a7da1 to https://genshin-optimizer-prs.github.io/pr/2593/frontend (Takes 3-5 minutes after this completes to be available) [Fri Jan 10 02:24:23 UTC 2025] - Deleted deployment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/gi/sheets/src/Characters/Citlali/index.tsx (1)
186-190: Consider improving readability of the condition chain.While the logic is correct, the nested conditions could be more readable. Consider extracting the condition chain into separate variables with descriptive names.
-const c2ShieldEleMas = unequal( - target.charKey, - key, - equal(target.charKey, input.activeCharKey, c2ShieldEleMas_disp) -) +const isNotSelf = unequal(target.charKey, key) +const isActiveCharacter = equal(target.charKey, input.activeCharKey, c2ShieldEleMas_disp) +const c2ShieldEleMas = isNotSelf(isActiveCharacter)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/gi/sheets/src/Characters/Citlali/index.tsx(6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: call-build / build
- GitHub Check: lint
🔇 Additional comments (4)
libs/gi/sheets/src/Characters/Citlali/index.tsx (4)
158-173: LGTM! Well-structured implementation of Citlali's C1 buff.The implementation correctly:
- Maps damage increase to specific attack types (NA, CA, PA, skill, burst)
- Prevents self-application through target character key check
- Calculates buff based on elemental mastery
260-261: LGTM! Correct usage of display nodes in UI.Using
c1BladeConsume_dmgInc_dispensures the UI shows all possible buff types, which is the expected behavior.
296-296: LGTM! Correct application of team buff.Using the filtered version
c1BladeConsume_dmgIncinteamBuff.premodensures proper buff application to team members only.
529-531: LGTM! Clean implementation of UI fields.The implementation elegantly maps all buff types to UI fields using
Object.valuesand array mapping.
Describe your changes
Issue or discord link
Testing/validation
Shows Citlali C1 not applying to self, C1 buff changed to specific attack types, and C1 header fixed
Shows Thousand Blazing Suns header fixed
Shows Mavuika C2 warning
Shows Mavuika C2 not changing damage numbers for flamestrider/burst
Shows Mavuika C2 warning goes away on C6
Shows Mavuika C2 def shred applying to flamestrider/burst, on C6
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-cilocally to validate format and lint.Summary by CodeRabbit
Summary by CodeRabbit
Localization
Character Updates
Weapon Improvements