Fix Chasca/Mav bugs

[nguyentvan7]

Describe your changes

• Fix Chasca A1 applying to A4 (verified this is correct behavior in-game)
• Fix Mav burst buff looking at skill level index

Issue or discord link

• https://discord.com/channels/785153694478893126/1310833666381053962/1320459604567785614
• https://discord.com/channels/785153694478893126/1324288981260697660

Testing/validation

Burst buff changes based on burst level now

Chasca A4 damage is unaffected by A1 toggle

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

• I have commented my code in hard-to understand areas.
• I have made corresponding changes to README or wiki.
• For front-end changes, I have updated the corresponding English translations.
• I have run yarn run mini-ci locally to validate format and lint.
• If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

Summary by CodeRabbit

• Bug Fixes
  • Updated damage calculation logic for characters Chasca and Mavuika
  • Refined damage increment computations for burst-related abilities
  • Adjusted damage formula parameters to improve accuracy of character damage calculations

[coderabbitai]

Walkthrough

The pull request introduces modifications to two character-specific damage calculation files for Chasca and Mavuika in the Genshin Impact (GI) sheets library. The changes simplify damage formula calculations for Chasca by removing additional modifiers and update Mavuika's damage increment calculations to use burst index instead of skill index, potentially adjusting how character ability damages are computed.

Changes

File	Change Summary
libs/gi/sheets/src/Characters/Chasca/index.tsx	Simplified damage node calculations by removing multiFireAddl and additional modifiers from passive2 section
libs/gi/sheets/src/Characters/Mavuika/index.tsx	Updated damage increment calculations to use burstIndex instead of skillIndex for sunfell_dmgInc, flameNormal_dmgInc, and flameCharged_dmgInc

Poem

🔥 Damage formulas dance and sway,
Chasca's shells, Mavuika's play,
Indices shift, modifiers flee,
Code rabbits hop with glee! 🐰
Calculations bloom anew today

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4826ca and 264a36d.

📒 Files selected for processing (2)

• libs/gi/sheets/src/Characters/Chasca/index.tsx (2 hunks)
• libs/gi/sheets/src/Characters/Mavuika/index.tsx (2 hunks)

🔇 Additional comments (5)

libs/gi/sheets/src/Characters/Chasca/index.tsx (2)

199-199: Looks good!
This updated dmgNode call for Chasca’s passive2 Anemo damage is clean and aligns with the intended fix of isolating the A1 effect from the A4 damage calculations.

---

212-212: Synchronized shining shell logic
Similarly, referencing hitEle[eleKey] directly helps ensure the A1 toggle no longer impacts the A4 logic by bypassing the extra multipliers. The approach stays consistent with the rest of the file.

libs/gi/sheets/src/Characters/Mavuika/index.tsx (3)

131-131: Corrected index for burst-based damage
Switching from skillIndex to burstIndex for sunfell_dmgInc correctly aligns the damage increment with Mavuika’s burst level, fulfilling the PR objective.

---

139-139: Consistent burst index usage
Using burstIndex instead of skillIndex for the flameNormal_dmgInc calculation makes sense to ensure the buff scales properly with burst level.

---

149-149: Ensuring charged damage relies on the correct burst level
Likewise, referencing the burst index for flameCharged_dmgInc makes the damage increment fully consistent with the new burst-based logic.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

[frontend] [Thu Jan 2 15:15:09 UTC 2025] - Deployed e124b50 to https://genshin-optimizer-prs.github.io/pr/2589/frontend (Takes 3-5 minutes after this completes to be available)

[Thu Jan 2 15:35:18 UTC 2025] - Deleted deployment