Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.0] Backport fixes for safety warnings #5838

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented Mar 2, 2021

Status

Ready for review

Description of Changes

Backports #5837 .

  • Updates jinja dependency
  • adds ignores for unresolveable-on-Xenial dev-only warnings.

Testing

rmol added 2 commits March 2, 2021 16:16
(cherry picked from commit fca51cc)
- 39606: cryptography, update overflow. We're not passing large enough
chunks to update to trigger the bug.

- 39611: pyyaml, code execution via untrusted YAML. We're not using
pyyaml in a production capacity except in the admin tooling, which is
using trusted YAML.

- 39621: pylint, denial of service via inefficient regex. We're only
using pylint in development, on our own code.

(cherry picked from commit 26c7a72)
Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good to merge when CI passes.

@emkll emkll merged commit f110c74 into release/1.8.0 Mar 2, 2021
@emkll emkll deleted the backport-fix-safety-warnings branch March 2, 2021 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants