Fix safety warnings #5837
Merged
Fix safety warnings #5837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 39606: cryptography, update overflow. We're not passing large enough chunks to update to trigger the bug. - 39611: pyyaml, code execution via untrusted YAML. We're not using pyyaml in a production capacity except in the admin tooling, which is using trusted YAML. - 39621: pylint, denial of service via inefficient regex. We're only using pylint in development, on our own code.
zenmonkeykstop
approved these changes
Mar 2, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #5836.
Updates Jinja2 to 2.11.3. Ignores some other
safetywarnings (rationale in #5836 and in the commit message).Testing
make build-debsandmake build-debs-focalproducesecuredrop-app-codepackages containing Jinja2 2.11.3.Deployment
Updates Jinja2 in the admin tooling and securedrop-app-code package.
Checklist
If you made changes to the server application code:
make lint) and tests (make test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made non-trivial code changes:
Choose one of the following:
If you added or updated a code dependency:
Choose one of the following:
I have@kushaldas performed a diff review and pasted the contents to the packaging wiki