-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Jinja2 to 2.10.1, Ansible to 2.6.14 and SQLAlchemy to 1.3.0 #4346
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4346 +/- ##
===========================================
- Coverage 84.84% 84.76% -0.08%
===========================================
Files 44 44
Lines 2797 2797
Branches 305 305
===========================================
- Hits 2373 2371 -2
- Misses 357 358 +1
- Partials 67 68 +1
Continue to review full report at Codecov.
|
Used pkgdiff and GitHub to review the diffs: Jinja2-2.10 -> 2.10.1
Ansible 2.6.8 -> 2.6.14
SQLAlchemy 1.2.0 -> 1.3.3
|
Address CVE-2019-10906 develop-requirements uses Molecule and the version of Jinja used by Molecule is locked in https://github.com/ansible/molecule/blob/master/setup.cfg#L80 . This will require an upsteam change as pip will not be able to compile the requirements.
Address CVE-2019-7164 and CVE-2019-7548
4f7e8e1
to
2f0d141
Compare
I rebased this on latest |
SQLAlchemy output has changed slightly in newer versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
provided CI passes, this is good to merge. thanks for diff/changelog review @emkll
Status
Ready for review
Description of Changes
Closes #4345, Closes #4350, towards #4343 :
dev-requirements.txt cannot be updated yet due to molecule pinning version of Jinja2: https://github.com/ansible/molecule/blob/master/setup.cfg#L80
An upstream issue has been opened to track
Testing
Minor version bumps and automated testing should have sufficient coverage
develop-requirements.txt
: that will require updating the molecule dependency.Deployment
Checklist
If you made non-trivial code changes: