Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jinja to 2.10.1 #4343

Closed
emkll opened this issue Apr 12, 2019 · 4 comments · Fixed by #4865
Closed

Update Jinja to 2.10.1 #4343

emkll opened this issue Apr 12, 2019 · 4 comments · Fixed by #4865
Assignees
Labels
Milestone

Comments

@emkll
Copy link
Contributor

emkll commented Apr 12, 2019

Description

The version of Jinja used is vulnerable to CVE-2019-10906, see pallet's advisory for more details.

Since neither SecureDrop nor Flask uses Jinja's SandboxedEnvironment, this vulnerability should not be exploitable on SecureDrop instances. It is however used in the development environment by sphynx and mypy (but don't use the format_map method that could be used to escape the sandbox).

Regardless, we should still update the dependency to ensure future functionality is secure and to reduce alert noise.

@redshiftzero
Copy link
Contributor

redshiftzero commented Apr 15, 2019

upstream issue: ansible/molecule#1976

@redshiftzero
Copy link
Contributor

the 2.20.2 release of molecule can be used now

@redshiftzero
Copy link
Contributor

scratch that, that release is not from the main branch, it's from stable/2.20 which does not have the fix (ref: https://github.com/ansible/molecule/tree/stable/2.20)

@redshiftzero
Copy link
Contributor

we can now update to molecule 2.22 to resolve this: https://github.com/ansible/molecule/blob/2.22/setup.cfg#L84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants