[xenial] resolve gpg IMPORT_OK status code test failures #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.1.1 is the default version of gpg2 in xenial 1.4.20 is the default version of gpg in xenial If we do not specify the binary, we can get divergence between test and dev/staging/prod.
5 tasks
heartsucker
approved these changes
Jan 18, 2019
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Fixes #4038
After investigation, not specifying the gpg binary to be
gpg2in test setup code was the source of theIMPORT_OKrelated test failures. This caused the divergence between test and dev/staging/prod, where we usegpg2.Testing
There should be no
IMPORT_OKrelated test failures in the xenial app test CI job.The test noted in the #4038 ticket (
tests/test_integration.py::test_submit_message) should pass.The only gpg-related failures in the test output (look at the integration tests) of the xenial job should be due to #4013 (
PINENTRY)Deployment
This is a test only change, so no implications for deployment.
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development containerIf you made non-trivial code changes: