Fixes #4038 python-gnupg works with gpg binary #4040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the python-gnupg to work properly on Xenial, we should call `gpg` binary instead of `gpg2` (which we use in Trusty).
|
Nice! So the test plan here should indicate that the integration tests should pass (not the 2fa tests), right? Does this also resolve #4013? |
It should, but, it seems I will need both is one and also #4041 in the same PR to make things working. Let me try another local branch first and then will create a new PR. |
|
good news! check out #4045. gonna close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
DO NOT MERGE
Description of Changes
Fixes #4038
For the python-gnupg to work properly on Xenial, we should
call
gpgbinary instead ofgpg2(which we use in Trusty).Testing
To view the effected 2fa tests:
$ BASE_OS=xenial securedrop/bin/dev-shell bin/run-test -v tests/test_2fa.pymake test-xenialDeployment
We will have to verify in the upgrade story.
Checklist
If you made changes to the server application code:
make ci-lint) and tests (make -C securedrop test) pass in the development containerIf you made changes to
securedrop-admin:make -C admin test) pass in the admin development containerIf you made changes to the system configuration:
If you made non-trivial code changes:
If you made changes to documentation:
make docs-lint) passed locally