Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminology.rst: fixed grammer issues #3045

Merged
merged 1 commit into from
Feb 21, 2018

Conversation

Anonymous26
Copy link
Contributor

@Anonymous26 Anonymous26 commented Feb 21, 2018

Status

Ready for review

Description of Changes

Relates-to: #3012
Fixed few grammatical errors

Checklist

If you made changes to the app code:

  • Unit and functional tests pass on the development VM

If you made changes to the system configuration:

If you made changes to documentation:

  • Doc linting passed locally

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #3045 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3045   +/-   ##
========================================
  Coverage    88.26%   88.26%           
========================================
  Files           32       32           
  Lines         1849     1849           
  Branches       212      212           
========================================
  Hits          1632     1632           
  Misses         167      167           
  Partials        50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23fbdd2...91ce938. Read the comment docs.

@ghost ghost added bug docs labels Feb 21, 2018
@heartsucker heartsucker requested a review from a user February 21, 2018 09:17
@heartsucker
Copy link
Contributor

Assigning @dachary as the reviewer since he opened the original ticket.

@ghost
Copy link

ghost commented Feb 21, 2018

@heartsucker these are English grammar issues and I'm unable to review I'm afraid. Not because I don't want to ! Because my english is not so well ;-)

@ghost ghost removed their request for review February 21, 2018 09:26
@heartsucker
Copy link
Contributor

Ok, so then is there anything in the original ticket that you wanted covered that does not appear covered by this PR?

@ghost
Copy link

ghost commented Feb 21, 2018

Ok, so then is there anything in the original ticket that you wanted covered that does not appear covered by this PR?

There still are issues to be fixed so I changed Fixed into Relates to in the message so the issue is not closed. But this PR is good to merge as far as I'm concerned !

@heartsucker heartsucker merged commit a42f60e into freedomofpress:develop Feb 21, 2018
@heartsucker
Copy link
Contributor

Thanks @Anonymous26!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants