Feature/responsive #2891
Merged
Feature/responsive #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the width for attachment and message in percentage instead of pixels. Signed-off-by: Saptak Sengupta <[email protected]>
Panel selected was wrapping weirdly in some width, so I changed the code to make it use flex for screen above 768px. This problem was there in all the websites using panel and header. Signed-off-by: Saptak Sengupta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #2891 +/- ##
========================================
Coverage 85.55% 85.55%
========================================
Files 31 31
Lines 1917 1917
Branches 214 214
========================================
Hits 1640 1640
Misses 228 228
Partials 49 49Continue to review full report at Codecov.
|
redshiftzero
approved these changes
Jan 18, 2018
ghost
added
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This pull request addresses responsiveness of frontend in the headers
and panel sections.
#1357 .
Changes proposed in this pull request:
I changed it to use Flexbox instead for media screen width above 768px. Now it looks like this:
This fix will affect almost all the pages except for the home page
Checklist
If you made changes to the app code: