-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make HTML/CSS responsive #1357
Comments
I can help with this, but it would be helpful if someone could merge #1349 first. We already have ugliness with the new wordlist because of the longer words. |
Sorry about the holdup on #1349, @heartsucker—those changes are in |
Work tracked in branch |
@SaptakS please have a look :) |
@kushaldas sure. I will try to contribute and make the pages more responsive in case they aren't. Thanks. 😃 |
There is one more thing that I wanted to ask. Apart from changing the fixed sizes (in pixels) to maybe percentage or Say, for example, in the /generate page, in wide screen, the differently sized buttons look good, but in narrower screens it looks weird: Wide Screen:Narrow Screen: |
@SaptakS note that for this specific page we removed the USE EXISTING CODENAME button so this won't be an issue anymore. |
what is the progress, any update? I could help ... |
As the above comments and PRs show, a lot of work has been done on this since the issue was filed, and both JI and SI should render responsively. Additional improvements, e.g., to table rendering, can be filed as separate issues. |
Currently many of the elements have fixed sizes (in pixels). This led to some ugly and poorly sized containers for the German translations in #1103 because of long words. It would probably look equally bad with very short words as in Chinese.
Before piling on more features, it might make sense to refactor the HTML/CSS (or hopefully SASS #1349) to support containers that resize depending on content size (as well as possibly monitor size). As I'm not usually a frontend dev, I'd roll it all by hand and skip a framework.
Currently there are a lot of features that require front changes, so it would be good to make this change before starting any of the others: #1356, #1355, #1354, #1353, #1171, #1170, (plus a nasty rebase of #1103)
The text was updated successfully, but these errors were encountered: