Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HTML/CSS responsive #1357

Closed
heartsucker opened this issue Jul 6, 2016 · 10 comments
Closed

Make HTML/CSS responsive #1357

heartsucker opened this issue Jul 6, 2016 · 10 comments
Labels
CSS (Formerly also included SASS) help wanted Issues we would definitely appreciate volunteer help with HTML i18n Anything related to translation or internationalization of SecureDrop source interface (SI)

Comments

@heartsucker
Copy link
Contributor

heartsucker commented Jul 6, 2016

Currently many of the elements have fixed sizes (in pixels). This led to some ugly and poorly sized containers for the German translations in #1103 because of long words. It would probably look equally bad with very short words as in Chinese.

Before piling on more features, it might make sense to refactor the HTML/CSS (or hopefully SASS #1349) to support containers that resize depending on content size (as well as possibly monitor size). As I'm not usually a frontend dev, I'd roll it all by hand and skip a framework.

Currently there are a lot of features that require front changes, so it would be good to make this change before starting any of the others: #1356, #1355, #1354, #1353, #1171, #1170, (plus a nasty rebase of #1103)

@heartsucker
Copy link
Contributor Author

I can help with this, but it would be helpful if someone could merge #1349 first. We already have ugliness with the new wordlist because of the longer words.

screenshot - 11102016 - 11 10 43 am

@conorsch
Copy link
Contributor

Sorry about the holdup on #1349, @heartsucker—those changes are in develop now, so have at it!

@heartsucker
Copy link
Contributor Author

@conorsch No worries. I'm probably going to hold off on this since it looks like @ninavizz has some more major changes to the UI in the pipe, and any changes I make might conflict with that.

Also related: #1450

@heartsucker heartsucker self-assigned this Aug 30, 2017
@heartsucker heartsucker added CSS (Formerly also included SASS) i18n Anything related to translation or internationalization of SecureDrop HTML in progress source interface (SI) labels Aug 30, 2017
@heartsucker
Copy link
Contributor Author

Work tracked in branch responsive-css.

@heartsucker heartsucker removed their assignment Sep 14, 2017
@redshiftzero redshiftzero added the help wanted Issues we would definitely appreciate volunteer help with label Nov 2, 2017
@ghost ghost removed the in progress label Dec 4, 2017
@kushaldas
Copy link
Contributor

@SaptakS please have a look :)

@SaptakS
Copy link
Contributor

SaptakS commented Dec 5, 2017

@kushaldas sure. I will try to contribute and make the pages more responsive in case they aren't. Thanks. 😃

@SaptakS
Copy link
Contributor

SaptakS commented Jan 4, 2018

There is one more thing that I wanted to ask. Apart from changing the fixed sizes (in pixels) to maybe percentage or vw/vh, one more thing that we often see is though things resize like they should with screen size, somethings appear better when done differently in mobile.

Say, for example, in the /generate page, in wide screen, the differently sized buttons look good, but in narrower screens it looks weird:

Wide Screen:

screen shot 2018-01-04 at 6 12 49 pm

Narrow Screen:

screen shot 2018-01-04 at 6 13 06 pm

@ghost
Copy link

ghost commented Jan 4, 2018

@SaptakS note that for this specific page we removed the USE EXISTING CODENAME button so this won't be an issue anymore.

@good-lly
Copy link

good-lly commented Sep 8, 2019

what is the progress, any update? I could help ...

@eloquence
Copy link
Member

As the above comments and PRs show, a lot of work has been done on this since the issue was filed, and both JI and SI should render responsively. Additional improvements, e.g., to table rendering, can be filed as separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS (Formerly also included SASS) help wanted Issues we would definitely appreciate volunteer help with HTML i18n Anything related to translation or internationalization of SecureDrop source interface (SI)
Projects
None yet
Development

No branches or pull requests

8 participants