Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download all submissions #1171

Closed
tildelowengrimm opened this issue Nov 3, 2015 · 6 comments
Closed

Download all submissions #1171

tildelowengrimm opened this issue Nov 3, 2015 · 6 comments

Comments

@tildelowengrimm
Copy link

If there are multiple sources, their submissions must be downloaded individually. When there are lots of submissions, that can be quite laborious.

@garrettr
Copy link
Contributor

garrettr commented Nov 4, 2015

This is also easy to implement. I think we should add all of the following:

  1. A "Download all" button on each source's page, and/or a "download all" button in the entry for each source on the main Document Interface page
  2. A "Download all unread" button on the main page, which is a one-click download of unread submissions from all sources.
  3. A "Download all" button on the main page, which is a one-click download of all submissions from all sources.
    • This button should have a warning dialog that tells you how big this download is going to be, and gives you the option to continue or cancel it. This could easily grow to GBs after running a public instance for a few weeks or months, and it there are issues with downloading that much data on the Journalist Workstation because:
      1. It's over Tor, so it could take a very long time (hours or days).

      2. The Journalist Workstation uses Tails, which writes to a ramdisk by default - so the maximum file you can download is the amount of RAM on your workstation (minus the amount needed to run Tails and its applications). This could easily be exceeded by downloading all submissions from a long-running SeucreDrop.

        I'm not sure what happens when you try to download a file that's too large to fit in memory on Tails. It's probably not good. You could potentially also write to the Persistent volume of the Journalist Workstation device, but that would require a manual decision from the user (Tor Browser defaults to downloading files to ~/Tor Browser, and you have to manually switch it to ~/Persistent/Tor Browser in the file picker). Even in that case, the Journalist Workstation is usually a smallish USB (32-64 GB), so even then you might not have enough space.

  4. We could also consider offering "Download unread from selected sources" and "Download all from selected sources" to the main page (similar to the "Delete selected", "Star selected", and "Unstar selected" options that are currently present).

@pwplus
Copy link
Contributor

pwplus commented Nov 5, 2015

I would like to work on this. I'll try to finish it by the end of Saturday which would correspond with the hackathon (unfortunately I'm in Austin, not California). Is that good with you guys?

@garrettr
Copy link
Contributor

garrettr commented Nov 7, 2015

@pwplus That's great! I'll add a card to the hackathon Trello board noting that you're working on this. If you want to work with us on Gitter/Trello, check out the info in this Trello card: https://trello.com/c/MACCDJXy/1-getting-started 😄

@garrettr
Copy link
Contributor

garrettr commented Nov 7, 2015

@pwplus Also, feel free to submit your work in smaller, modular PR's for each of the 4 types of "multiple download" buttons I described in #1171 (comment) if you think that makes sense.

@pwplus
Copy link
Contributor

pwplus commented Nov 7, 2015

I've got the first button working. I'll make a PR. I just got my phone charger back, so I wasn't able to test anything until just now since I had no Google Authenticator.

@conorsch
Copy link
Contributor

Resolved via #1467 and #1486. Will ship in 0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants