Fixes GUI feedback in sd-journalist #149
Conversation
The `python-qt4` package is required for the GUI feedback integration, so status messages can be displayed to the user. The package isn't present by default, and we need it in sd-journalist. Since we don't have SD TemplateVMs yet, we're adding the package to the base template, installing in `whonix-ws-14`, rather than `sd-journalist`, to get persistence for the package.
conorsch
changed the title
|
@emkll, if you have a patch for the python3 bytes/string pipe error, please append here. |
Due to changes in Python3 string handling, strings must be encoded prior to being sent to the pipe, as it may introduce a type error such as: `TypeError: a bytes-like object is required, not 'str'`
|
Went through the test plan for 40d73f3, lgtm. I've also added a fix for the process submission in 9b6ec99. |
dom0/sd-journalist.sls
Outdated
| # * python-futures required bootstrap Salt support | ||
| # * python-qt4 required for sd-process-feedback GUI integration | ||
| # | ||
| qvm-run -a whonix-ws-14 "sudo apt-get install -qq python-futures python-qt4": |
There was a problem hiding this comment.
This is a nit .. but can we use the salt paradigm of
install qt4:
cmd.run:
- name: qvm-run -a whonix-ws-14 "sudo apt-get install -qq python-futures python-qt4"instead?
There was a problem hiding this comment.
word, testing this PR with this suggested change
|
I'm seeing the feedback widget get stuck on "Initial download bundle created." Looks like others are able to decrypt and view test submissions fine with these changes, so I'll consider it specific to my dev env for now. |
@redshiftzero pointed me to the solution: the qubes rpc rules in dom0 had broken as a result of a whitespace error during review of #140 (fixed during review, possibly in #146). Not reopening because we already have #147 tracking the addition of dom0 rpc tests. |
Installs python-qt4 in whonix-ws-14
The
python-qt4package is required for the GUI feedback integration,so status messages can be displayed to the user. The package isn't
present by default, and we need it in sd-journalist. Since we don't
have SD TemplateVMs yet, we're adding the package to the base template,
installing in
whonix-ws-14, rather thansd-journalist, to getpersistence for the package.
Marking as WIP, because we still have another follow-up to fix the submission process pipeline. See #127 (comment) for details; I propose we append a resolving commit here, then use the following test plan.
Testing
make allindom0.qvm-shutdown --wait whonix-ws-14, to ensure the modified TemplateVM will be used on subsequent creation.make allindom0.make testand confirm no errors.sd-journalistVM.