Yet even more replacing sed commands #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redshiftzero
force-pushed
the
113-more-replace-sed-commands
branch
from
5b3447c to
26fa114
Compare
redshiftzero
approved these changes
Sep 13, 2018
6 tasks
This was referenced Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on @charles-boyd 's recent work (https://github.com/freedomofpress/securedrop-workstation/pull/140/files) to replace the ugly
sedcommands in some of our Salt states. I included @conorsch 's state naming suggestions, and used Salt'sfile.prependoperation (rather thanfile.line), which I found to be more successful for avoiding the same line repeatedly.