Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make requests and urllib3 optional dependencies #1761

Closed
heartsucker opened this issue May 8, 2019 · 0 comments · Fixed by #1718
Closed

make requests and urllib3 optional dependencies #1761

heartsucker opened this issue May 8, 2019 · 0 comments · Fixed by #1718
Labels
proxy v2 sdk

Comments

@heartsucker
Copy link
Contributor

These are only needed for development and testing using HTTP against a server. In production, they are not needed since the SDK uses qrexec-client-vm for RPC. Removing these would help trim down the dependencies shipped with the client.
@legoktm legoktm added the sdk label Jan 5, 2024
@legoktm legoktm transferred this issue from freedomofpress/securedrop-sdk Jan 5, 2024
legoktm added a commit that referenced this issue Mar 5, 2024
@legoktm
Remove requests dependency
0e505f9 
Fixes #1761.
@legoktm legoktm moved this to In Progress in SecureDrop dev cycle Mar 5, 2024
legoktm added a commit that referenced this issue Mar 5, 2024
@legoktm
Remove requests dependency
2ec6358 
Fixes #1761.
legoktm added a commit that referenced this issue Mar 7, 2024
@legoktm
Remove requests dependency
5161952 
Fixes #1761.
legoktm added a commit that referenced this issue May 1, 2024
@legoktm
Remove requests dependency
d595720 
Fixes #1761.
legoktm added a commit that referenced this issue May 1, 2024
@legoktm
Remove requests dependency
7798c8d 
Fixes #1761.
legoktm added a commit that referenced this issue May 2, 2024
@legoktm
Remove requests dependency
1bf27a9 
Fixes #1761.
legoktm added a commit that referenced this issue May 2, 2024
@legoktm
Remove requests dependency
4d9ac8b 
Fixes #1761.
legoktm added a commit that referenced this issue May 2, 2024
@legoktm
Remove requests dependency
1a83c24 
Fixes #1761.
legoktm added a commit that referenced this issue May 2, 2024
@legoktm
Remove requests dependency
b58fc2d 
Fixes #1761.
legoktm added a commit that referenced this issue May 2, 2024
@legoktm
Remove requests dependency
7bb77d7 
Fixes #1761.
@legoktm legoktm mentioned this issue May 2, 2024
Merged
16 tasks
legoktm added a commit that referenced this issue May 2, 2024
@legoktm
Remove requests dependency
3e50ec7 
Fixes #1761.
cfm pushed a commit that referenced this issue May 8, 2024
@legoktm @cfm
Remove requests dependency
75f0449 
Fixes #1761.
legoktm added a commit that referenced this issue May 15, 2024
@legoktm
Remove requests dependency
d45cdc7 
Fixes #1761.
micahflee pushed a commit that referenced this issue May 16, 2024
@legoktm @micahflee
Remove requests dependency
104a114 
Fixes #1761.
@github-project-automation github-project-automation bot moved this from In Progress to Done in SecureDrop dev cycle May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proxy v2 sdk
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement proxy v2 architecture, in Rust freedomofpress/securedrop-client
2 participants
@legoktm @heartsucker