Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use concat return value for Trigger names #11592

Merged
merged 1 commit into from Nov 20, 2018
Merged

fix: use concat return value for Trigger names #11592

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: use concat return value for Trigger names
  • Loading branch information
Daniel Ruf committed Nov 19, 2018
commit 5b9279812ff4116ca3dcdd5380abab876c95d141
2 changes: 1 addition & 1 deletion js/foundation.util.triggers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ Triggers.Initializers.addClosemeListener = function(pluginName) {
if(typeof pluginName === 'string'){
plugNames.push(pluginName);
}else if(typeof pluginName === 'object' && typeof pluginName[0] === 'string'){
plugNames.concat(pluginName);
plugNames = plugNames.concat(pluginName);
}else{
console.error('Plugin names must be strings');
}
Expand Down