Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use concat return value for Trigger names #11592

Merged
merged 1 commit into from Nov 20, 2018
Merged

fix: use concat return value for Trigger names #11592

merged 1 commit into from Nov 20, 2018

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Nov 19, 2018 •
edited
Loading

Description

It seems the return value of the concat is not used in the Triggers which creates the trigger name. We should check if this is the correct approach as the unit tests do not fail with and without this change.

  • Closes

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@ncoden ncoden self-requested a review November 19, 2018 07:44
ncoden
ncoden approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thx @DanielRuf

@ncoden ncoden merged commit 86321d0 into foundation:develop Nov 20, 2018
@DanielRuf DanielRuf deleted the fix/triggers-use-concat-return-value branch November 20, 2018 08:55
ncoden pushed a commit that referenced this pull request Jan 11, 2019
@ncoden
Use pull request #11592 from DanielRuf/fix/triggers-use-concat-return…
ad2a6d6 
…-value for v6.5.0

5b92798 fix: use concat return value for Trigger names

Signed-off-by: Nicolas Coden <[email protected]>
@ncoden ncoden mentioned this pull request Jan 12, 2019
Merged
11 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
javascript Triggers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden