release: merge set of changes for v1.2.0 #299

willmj · 2024-08-14T18:44:00Z

Description of the change

v1.2.0 release

Related issue number

How to verify the PR

Was the PR tested

I have added >=1 unit test(s) for every new method I have added.
I have ensured all unit tests pass

Signed-off-by: Will Johnson <[email protected]>

Signed-off-by: Abhishek <[email protected]>

…thon logger Signed-off-by: Abhishek <[email protected]>

* initial code for deleting lm_head Signed-off-by: Anh-Uong <[email protected]> * fix logic for copying checkpoint Signed-off-by: Anh-Uong <[email protected]> * fix check that embed_tokens and lm_head weights are the same Signed-off-by: Anh-Uong <[email protected]> * fix warning assertion Signed-off-by: Anh-Uong <[email protected]> * fix lm_head check, remove test Signed-off-by: Anh-Uong <[email protected]> * small fixes from code review Signed-off-by: Anh-Uong <[email protected]> * fmt Signed-off-by: Anh-Uong <[email protected]> --------- Signed-off-by: Anh-Uong <[email protected]> Co-authored-by: Anh-Uong <[email protected]> Signed-off-by: Abhishek <[email protected]>

Signed-off-by: Angel Luu <[email protected]>

Signed-off-by: Abhishek <[email protected]>

Signed-off-by: Angel Luu <[email protected]>

Signed-off-by: Abhishek <[email protected]>

Add config_utils tests

* feat: On save event added to callback Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Removed additional bracket Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Removed additional bracket Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Format issues resolved Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: rebase with upstream and add new line Signed-off-by: Mehant Kammakomati <[email protected]> --------- Signed-off-by: Padmanabha V Seshadri <[email protected]> Signed-off-by: Mehant Kammakomati <[email protected]> Co-authored-by: Mehant Kammakomati <[email protected]>

* feat: All metric handling changes Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Format issues Signed-off-by: Padmanabha V Seshadri <[email protected]> --------- Signed-off-by: Padmanabha V Seshadri <[email protected]>

* feat: Added the triggered login in the operation Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Formatting issues Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Added default config Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Moved the variable to right scope Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Checked added to validate config log level Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Removed some unwanted log file Signed-off-by: Padmanabha V Seshadri <[email protected]> --------- Signed-off-by: Padmanabha V Seshadri <[email protected]>

Signed-off-by: Anh-Uong <[email protected]>

* refactor code to preprocess datasets Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: Sukriti-Sharma4 <[email protected]> * fix formatting Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: Sukriti-Sharma4 <[email protected]> * allow input/output in validate args Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: Sukriti-Sharma4 <[email protected]> * format input/output JSON and mask Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: Sukriti-Sharma4 <[email protected]> * function to return suitable collator Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: Sukriti-Sharma4 <[email protected]> * add tests for SFT Trainer input/output format Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: Sukriti-Sharma4 <[email protected]> * remove unused functions Co-authored-by: Alex-Brooks <[email protected]> Signed-off-by: Sukriti-Sharma4 <[email protected]> * add eos token to input/output format Signed-off-by: Sukriti-Sharma4 <[email protected]> * fix tests Signed-off-by: Sukriti-Sharma4 <[email protected]> * improve docstrings Signed-off-by: Sukriti-Sharma4 <[email protected]> * keeping JSON keys constant Signed-off-by: Sukriti-Sharma4 <[email protected]> * support for input/output format Signed-off-by: Sukriti-Sharma4 <[email protected]> * formatting fixes Signed-off-by: Sukriti-Sharma4 <[email protected]> * update rEADME formats Signed-off-by: Sukriti-Sharma4 <[email protected]> * formatting README Signed-off-by: Sukriti-Sharma4 <[email protected]> --------- Signed-off-by: Sukriti-Sharma4 <[email protected]> Co-authored-by: Alex-Brooks <[email protected]>

This reverts commit f57ff63. Signed-off-by: Anh-Uong <[email protected]>

Signed-off-by: Harikrishnan Balagopal <[email protected]>

Signed-off-by: Will Johnson <[email protected]>

Signed-off-by: Abhishek <[email protected]>

* Add a dockerfile argument at the end of final layer to enable aimstack. Currenlty guarded by a dockerfile argument. Signed-off-by: Dushyant Behl <[email protected]> * Set the default value of ENABLE_AIM to false Signed-off-by: Dushyant Behl <[email protected]> --------- Signed-off-by: Dushyant Behl <[email protected]>

* Add unit test to verify target_modules defaults correctly Signed-off-by: Will Johnson <[email protected]> * Add sft_trainer.main test to ensure target modules properly default for LoRA when set to None from CLI Signed-off-by: Will Johnson <[email protected]> * fmt Signed-off-by: Will Johnson <[email protected]> * Use model_args instead of importing, fix nits Signed-off-by: Will Johnson <[email protected]> * Add test to ensure target_modules defaults to None in job config Signed-off-by: Will Johnson <[email protected]> * Add additional check, fix nits Signed-off-by: Will Johnson <[email protected]> --------- Signed-off-by: Will Johnson <[email protected]>

Signed-off-by: Dushyant Behl <[email protected]>

…e. (#290) Signed-off-by: Dushyant Behl <[email protected]>

Signed-off-by: Abhishek <[email protected]>

Signed-off-by: Dushyant Behl <[email protected]>

Signed-off-by: Padmanabha V Seshadri <[email protected]>

Signed-off-by: Abhishek <[email protected]>

Signed-off-by: Anh-Uong <[email protected]>

Signed-off-by: Abhishek <[email protected]>

Fix: Removal of transformers logger and addition of python native logger

…p, on_substep_end (#293) Signed-off-by: Padmanabha V Seshadri <[email protected]>

Signed-off-by: James Busche <[email protected]> Co-authored-by: Anh Uong <[email protected]>

Signed-off-by: Will Johnson <[email protected]> Co-authored-by: Anh Uong <[email protected]>

* add save_model_dir flag for final checkpoint Signed-off-by: Anh-Uong <[email protected]> * remove output_dir logic, add save method Signed-off-by: Anh-Uong <[email protected]> * update accelerate_launch, remove save tokenizer Signed-off-by: Anh-Uong <[email protected]> * fix: put back creation of .complete file Signed-off-by: Anh-Uong <[email protected]> * fix failing tests and add new ones Signed-off-by: Anh-Uong <[email protected]> * tests: add sft_trainer test to train and save - small refactor of tests Signed-off-by: Anh-Uong <[email protected]> * add docs on saving checkpoints and fix help msg Signed-off-by: Anh-Uong <[email protected]> * update example and note best checkpoint Signed-off-by: Anh-Uong <[email protected]> * changes based on PR review Signed-off-by: Anh-Uong <[email protected]> * add logging to save, fix error out properly Signed-off-by: Anh-Uong <[email protected]> --------- Signed-off-by: Anh-Uong <[email protected]>

anhuong · 2024-08-14T21:03:37Z

@willmj I looked through all of the commits and they look good except for the most recent commit from you. This does not look to be signed,

Merge tag 'v1.2.0-rc.1' into release

Some of the PRs that were done via merge commit instead of squash commit also have lots of commits spread out which makes it harder to read. So we should do squash commits going forward.

Signed-off-by: Will Johnson <[email protected]>

willmj and others added 30 commits July 29, 2024 09:52

Set default value of target_modules to be None in LoraConfig

ae1625b

Signed-off-by: Will Johnson <[email protected]>

Removal of transformers logger and addition of python logger

2b4ce8d

Signed-off-by: Abhishek <[email protected]>

FMT and lint check: Removal of transformers logger and addition of py…

76fffc5

…thon logger Signed-off-by: Abhishek <[email protected]>

Merge branch 'main' into fix_logging

2e36147

Add config_utils tests

a8bd8dd

Signed-off-by: Angel Luu <[email protected]>

Fix fmt

7054070

Signed-off-by: Angel Luu <[email protected]>

Separate tests out and use docstrings

906ce02

Signed-off-by: Angel Luu <[email protected]>

Update more field/value checks from HF defaults

3e831c6

Signed-off-by: Angel Luu <[email protected]>

Fix: Addition of env var TRANSFORMERS_VERBOSITY check

8846bc2

Signed-off-by: Abhishek <[email protected]>

FMT Fix: Addition of env var TRANSFORMERS_VERBOSITY check

4ed3878

Signed-off-by: Abhishek <[email protected]>

Add test for tokenizer in lora config (should be ignored)

dc32eda

Signed-off-by: Angel Luu <[email protected]>

Adding logging support to accelerate launch

efb8363

Signed-off-by: Abhishek <[email protected]>

FMT_FIX: Adding logging support to accelerate launch

2ecfaf7

Signed-off-by: Abhishek <[email protected]>

Merge pull request #262 from aluu317/test_config_utils

a9b8ec8

Add config_utils tests

Merge branch 'main' into fix_logging

f2e8afb

feat: All metric handling changes (#263)

71c3e8a

* feat: All metric handling changes Signed-off-by: Padmanabha V Seshadri <[email protected]> * fix: Format issues Signed-off-by: Padmanabha V Seshadri <[email protected]> --------- Signed-off-by: Padmanabha V Seshadri <[email protected]>

Merge branch 'main' into 1143

0bf6871

Merge branch 'main' into fix_logging

c44b1dc

limit peft deps until investigate (#274)

f57ff63

Signed-off-by: Anh-Uong <[email protected]>

Revert "limit peft deps until investigate (#274)" (#275)

c7589d1

This reverts commit f57ff63. Signed-off-by: Anh-Uong <[email protected]>

feat: per process state metric (#239)

1884f61

Signed-off-by: Harikrishnan Balagopal <[email protected]>

Modify test to pass with target_modules: None

a09f837

Signed-off-by: Will Johnson <[email protected]>

Merge branch 'main' into 1143

c15f4f9

Merge branch 'foundation-model-stack:main' into fix_logging

abd8abc

Logging changes and unit tests added

5d08efb

Signed-off-by: Abhishek <[email protected]>

willmj and others added 21 commits August 6, 2024 17:47

docs: Add documentation on experiment tracking. (#257)

d224be6

Signed-off-by: Dushyant Behl <[email protected]>

Ensure additional metadata to trackers don't throw error in happy cas…

baeecf1

…e. (#290) Signed-off-by: Dushyant Behl <[email protected]>

Merge remote-tracking branch 'upstream/main'

f0fcfdb

Merge branch 'main' into fix_logging

e65cb2d

PR Changes

4841119

Signed-off-by: Abhishek <[email protected]>

fix multiple runid creation bug with accelerate. (#268)

0a9d4a6

Signed-off-by: Dushyant Behl <[email protected]>

feat: logging control operation (#264)

ce965a8

Signed-off-by: Padmanabha V Seshadri <[email protected]>

Merge remote-tracking branch 'upstream/main'

fe8bb05

Metrics file epoch indexing from 0

5ecf4dd

Signed-off-by: Abhishek <[email protected]>

Revert last commit

89124ac

Signed-off-by: Abhishek <[email protected]>

fix run evaluation to get base model path (#273)

bb0caf9

Signed-off-by: Anh-Uong <[email protected]>

Merge remote-tracking branch 'upstream/main'

bddad06

Merge branch 'main' into fix_logging

0777460

PR Changes

3068f51

Signed-off-by: Abhishek <[email protected]>

PR Changes

0866bce

Signed-off-by: Abhishek <[email protected]>

Merge pull request #270 from Abhishek-TAMU/fix_logging

ee25de4

Fix: Removal of transformers logger and addition of python native logger

feat: Added additional events such as on_step_begin, on_optimizer_ste…

a40e138

…p, on_substep_end (#293) Signed-off-by: Padmanabha V Seshadri <[email protected]>

Always update setuptools to latest (#288)

6e7cea6

Signed-off-by: James Busche <[email protected]> Co-authored-by: Anh Uong <[email protected]>

Rename all fixtures with correct .jsonl extension (#295)

0aae2aa

Signed-off-by: Will Johnson <[email protected]> Co-authored-by: Anh Uong <[email protected]>

willmj requested review from anhuong, Ssukriti and alex-jw-brooks as code owners August 14, 2024 18:44

anhuong changed the title ~~v1.2.0 rc1~~ release: merge set of changes for v1.2.0 Aug 14, 2024

willmj force-pushed the v1.2.0-rc1 branch from f309821 to 0aae2aa Compare August 14, 2024 21:38

Merge tag 'v1.2.0-rc.1' into v1.2.0-rc1

6bcdf59

Signed-off-by: Will Johnson <[email protected]>

anhuong approved these changes Aug 14, 2024

View reviewed changes

anhuong merged commit 49305ad into release Aug 14, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

release: merge set of changes for v1.2.0 #299

release: merge set of changes for v1.2.0 #299

willmj commented Aug 14, 2024 •

edited by anhuong

Loading

anhuong commented Aug 14, 2024

release: merge set of changes for v1.2.0 #299

release: merge set of changes for v1.2.0 #299

Conversation

willmj commented Aug 14, 2024 • edited by anhuong Loading

Description of the change

Related issue number

How to verify the PR

Was the PR tested

anhuong commented Aug 14, 2024

willmj commented Aug 14, 2024 •

edited by anhuong

Loading