Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create attendee pdf for every ticket holder #7462

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

codedsun
Copy link
Contributor

Fixes #7397

Short description of what this resolves:

feat: Create attendee pdf for every ticket holder

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Nov 24, 2020
@codedsun
Copy link
Contributor Author

@iamareebjamal - Review now

Behaviour
image

Tested the frontend also, working fine

)
save_to_db(order)
# create order invoices pdf
order_tickets = OrderTicket.query.filter_by(order_id=order.id).all()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this indentation is wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@codedsun
Copy link
Contributor Author

@iamareebjamal - Review now!

@iamareebjamal iamareebjamal merged commit e10e235 into fossasia:development Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ticket PDF should exist for each attendee
2 participants