feat: Create attendee pdf for every ticket holder

fossasia · Nov 24, 2020 · 5f39f04 · 5f39f04
1 parent 4a77516
commit 5f39f04
Showing 1 changed file with 26 additions and 32 deletions.
diff --git a/app/api/helpers/order.py b/app/api/helpers/order.py
@@ -88,41 +88,35 @@ def create_pdf_tickets_for_holder(order):
         order.tickets_pdf_url = pdf
 
         for holder in order.ticket_holders:
-            if (not holder.user) or holder.user.id != order.user_id:
-                # holder is not the order buyer.
-                pdf = create_save_pdf(
-                    render_template(
-                        'pdf/ticket_attendee.html', order=order, holder=holder
-                    ),
-                    UPLOAD_PATHS['pdf']['tickets_all'],
-                    dir_path='/static/uploads/pdf/tickets/',
-                    identifier=order.identifier,
-                    extra_identifiers={'extra_identifier': holder.id},
-                    upload_dir='generated/tickets/',
-                )
-            else:
-                # holder is the order buyer.
-                pdf = order.tickets_pdf_url
+            # create attendee pdf for every ticket holder
+            pdf = create_save_pdf(
+                render_template('pdf/ticket_attendee.html', order=order, holder=holder),
+                UPLOAD_PATHS['pdf']['tickets_all'],
+                dir_path='/static/uploads/pdf/tickets/',
+                identifier=order.identifier,
+                extra_identifiers={'extra_identifier': holder.id},
+                upload_dir='generated/tickets/',
+            )
             holder.pdf_url = pdf
             save_to_db(holder)
 
-        # create order invoices pdf
-        order_tickets = OrderTicket.query.filter_by(order_id=order.id).all()
-
-        create_save_pdf(
-            render_template(
-                'pdf/order_invoice.html',
-                order=order,
-                event=order.event,
-                tax=order.event.tax,
-                order_tickets=order_tickets,
-            ),
-            UPLOAD_PATHS['pdf']['order'],
-            dir_path='/static/uploads/pdf/tickets/',
-            identifier=order.identifier,
-            upload_dir='generated/invoices/',
-        )
-        save_to_db(order)
+    # create order invoices pdf
+    order_tickets = OrderTicket.query.filter_by(order_id=order.id).all()
+
+    create_save_pdf(
+        render_template(
+            'pdf/order_invoice.html',
+            order=order,
+            event=order.event,
+            tax=order.event.tax,
+            order_tickets=order_tickets,
+        ),
+        UPLOAD_PATHS['pdf']['order'],
+        dir_path='/static/uploads/pdf/tickets/',
+        identifier=order.identifier,
+        upload_dir='generated/invoices/',
+    )
+    save_to_db(order)
 
 
 def create_onsite_attendees_for_order(data):