feat: Complete invoice generation #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 30, 2020
| try: | ||
| save_to_db(event_invoice) | ||
| except Exception as e: | ||
| # For some reason, like duplicate identifier, the record might not be saved, so we |
There was a problem hiding this comment.
line too long (102 > 90 characters)
| event = Event.query.get(event_id) | ||
| try: | ||
| # For keeping invoice numbers gapless and non-repeating, we need to generate invoices | ||
| # one at a time. Hence, we try acquiring an expiring lock for 20 seconds, and then retry. |
There was a problem hiding this comment.
line too long (97 > 90 characters)
|
|
||
| event = Event.query.get(event_id) | ||
| try: | ||
| # For keeping invoice numbers gapless and non-repeating, we need to generate invoices |
There was a problem hiding this comment.
line too long (93 > 90 characters)
| # SQLAlchemy returns touples instead of list of IDs | ||
| last_order_event_ids = [r[0] for r in last_order_event_ids] | ||
| events = ( | ||
| Event.query.filter(Event.owner != None) |
There was a problem hiding this comment.
comparison to None should be 'if cond is not None:'
|
This pull request introduces 1 alert when merging 597b190 into c96ccf0 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fossasia/open-event-frontend#5127