fix: update package.json files to comply with new parser #4749
Conversation
There was a problem hiding this comment.
Thanks for this work, Cristi! Looks great. And thanks for sending me the link to the PR that explains the new parser changes! I've got one question about clearing out one more set of squigglies but otherwise this is looking great.
| @@ -153,7 +153,7 @@ | |||
| }, | |||
| { | |||
| "command": "sfdx.force.test.view.runSingleTest", | |||
| "when": "view == sfdx.force.test.view && viewItem =~ /(apexTest)(_.*|\\b)/", | |||
| "when": "view == sfdx.force.test.view && viewItem =~ /(apexTest)(_.*||\\b)/", | |||
There was a problem hiding this comment.
dumb reg ex q. Seems like they moved to js style regular expressions. So did it just change for a|b -> a or b to a||b -> a or b?
There was a problem hiding this comment.
it seems so! According to this issue and this page
There was a problem hiding this comment.
hum...interestingly the matches example on that page uses the single |
There was a problem hiding this comment.
Oh right... mm then the || would be for other cases?
There was a problem hiding this comment.
dumb reg ex q. Seems like they moved to js style regular expressions. So did it just change for a|b -> a or b to a||b -> a or b?
it seems so! According to microsoft/vscode#175540 and this page
Hmm, would you mind pointing which wording made you think so? Because we didn't change how we interpret regex patterns, it's just I probably had worded myself poorly.
Also, I think you don't need to change a when clause if there are no errors underlined.
CristiCanizales
force-pushed
the
cristi/new-parser
branch
from
d0a81ba to
9afd40b
Compare
|
Remaining QE, given this is a dev-only impact:
|
There was a problem hiding this comment.
QA:
✅ - Builds locally, and also fixes the issue with the extra commands no longer appearing!
✅ - Extensions look good with VSIXes in 1.77.3
✅ - start function, lightning rename and lwc preview commands appear in proper context
✅ - Extensions look good with VSIXes in 1.75.1 (January build)
✅ - start function, lightning rename and lwc preview commands appear in proper context
What does this PR do?
What issues does this PR fix or reference?
@W-12645770@
Functionality Before
Functionality After