Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up: some when clauses in your extension may be broken with the next VS Code release #4726

Closed
ulugbekna opened this issue Mar 6, 2023 · 3 comments · Fixed by #4749
Closed

Comments

@ulugbekna
Copy link

Hi 👋

VS Code team engineer here 🙂

We're reworking how we parse when clause contexts and noticed that we may break some of the when clauses used in your extension. You can read more in this issue, which describes upcoming changes: new features, breakages, and migration advice (latest VS Code Insiders now has a linter for when clauses and runs the new parser as default). You can also leave us feedback there.

Thanks for a great extension, it's very popular!

Best,
Ulugbek

@AnanyaJha
Copy link
Collaborator

Thanks for sharing @ulugbekna! Appreciate the heads up, we'll get started on evaluating the impact to our Extension

@CristiCanizales
Copy link
Contributor

Hello @ulugbekna ! Hope you're doing great. Just to confirm, the or would be || now but not for the regex cases - that would still be |, right?
Thank you in advance!

@ulugbekna
Copy link
Author

Hi @CristiCanizales :-)

Hm, if I understand your question correctly, then yes, an || operator in a when clause and | in a regex pattern are unrelated.

Perhaps the updated docs help - https://code.visualstudio.com/api/references/when-clause-contexts#match-operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants