Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(segment): add fitted variant #702

Merged
merged 1 commit into from
Apr 29, 2019
Merged

feat(segment): add fitted variant #702

merged 1 commit into from
Apr 29, 2019

Conversation

lubber-de
Copy link
Member

Description

This PR adds the variants fitted, horizontally fitted and vertically fitted to the segment element, as is it already availble for menu

Testcase

https://jsfiddle.net/g7ha28wk/4/

Closes

Semantic-Org/Semantic-UI#6117
#701 (when the mentioned workaround is used)

@lubber-de lubber-de added type/feat Any feature requests or improvements lang/css Anything involving CSS state/awaiting-docs Pull requests which need doc changes/additions tag/sui-issue Taken from an existing Issue/PR of SUI labels Apr 26, 2019
@lubber-de lubber-de added this to the 2.7.5 milestone Apr 26, 2019
This was referenced Apr 26, 2019
Closed
Closed
exoego
exoego approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prudho
prudho approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@prudho prudho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami changed the title [Segment] Fitted variant similar to menu feat(segment): add fitted variant Apr 29, 2019
@y0hami y0hami merged commit f03c4ec into fomantic:develop Apr 29, 2019
@lubber-de lubber-de deleted the feat/fitted_segment branch April 29, 2019 10:26
@lubber-de lubber-de mentioned this pull request Apr 29, 2019
Merged
@lubber-de lubber-de added state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo and removed state/awaiting-docs Pull requests which need doc changes/additions labels Apr 29, 2019
@lubber-de lubber-de mentioned this pull request Apr 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

@prudho prudho prudho approved these changes

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

Assignees
No one assigned
Labels
lang/css Anything involving CSS state/has-docs A issue/PR which requires documentation changes and has the corresponding PR open in the docs repo tag/sui-issue Taken from an existing Issue/PR of SUI type/feat Any feature requests or improvements
Projects
None yet
Milestone
2.7.5
Development

Successfully merging this pull request may close these issues.
4 participants
@lubber-de @exoego @prudho @y0hami