-
-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Segment] Stacked loading segment doesn't work #701
Comments
Unfortunately this isn't going to work because the |
Ah, okay. I had seen the report from Semantic-Org/Semantic-UI/issues/6796 and thought I'd put it here since fomantic and semantic looked different. The padding would be less of an issue if we implemented Semantic-Org/Semantic-UI/issues/6117 too, the bot closed it on me |
@GammaGames Well...#702 😉 |
That was fast! All the rules make me think though, would it be worth it to make more general css to follow BEM better? Instead of having a :root {
--font-size: 1rem;
}
.small {
font-size: calc(var(--font-size) * 0.9);
}
.tiny {
font-size: calc(var(--font-size) * 0.8);
}
.mini {
font-size: calc(var(--font-size) * 0.7);
} Tests could be automatically generated using combinations of the lists of blocks, elements, and blocks and might end up being more exhaustive, though harder to verify. |
You are basically right, but it's definately a topic and goal for 3.x as this needs heavy refactoring |
I'll close this issue since this has a workaround suggested in #701 (comment) and labeled as wontfix. |
Bug Report
Steps to reproduce
Expected result
Stacked loading segment
Actual result
Non-stacked, semi-loading segment
Testcase
https://jsfiddle.net/Lxc6yr7v/
Screenshot (when possible)
Version
2.7.4
The text was updated successfully, but these errors were encountered: