-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply given API service client options #418
Conversation
lib/fog/google/shared.rb
Outdated
# @param [Hash] google_client_options Service client options to apply | ||
# @param [Hash] _ Rest of the options (for convenience, ignored) | ||
# @return [void] | ||
def apply_client_options(service, google_client_options: nil, **_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming/UncommunicativeMethodParamName: Method parameter must be at least 3 characters long.
f044b4f
to
42b8df5
Compare
@AlexanderZagaynov Thank you very much for the contribution! LGTM overall. If integration tests pass I'll try to merge this with 1.8.0 I'm planning to release anyway. |
@Temikus About testing - can you please give me a hint where to put those tests? fog-google/lib/fog/google/shared.rb Line 129 in 42b8df5
But I have no idea about proper way to do that. |
@AlexanderZagaynov I don't think we have a reasonable module to test Only thing I ask is - can you please give me a couple of examples of common use-cases? There are a lot of options so I want to be sure we're testing the right thing. |
@Temikus we're going to use that in a way like: conn = Fog::Compute::Google.new(google_client_options: { proxy_url: 'https://user:password@host:8080' })
conn.list_servers('') it should give |
@AlexanderZagaynov Thanks for the contribution, I've added a small test for it. It's not ideal but should cover at least a part of the risk surface. |
That feature was broken with Google's gem update and
this PR: 5ec9a15#diff-c6b2ed334d1938d66b4e168f255abbb7L140
Now it's back.