rename client's proxy option

[AlexanderZagaynov]

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1623862

In a recent google-api-ruby-client gem versions option proxy now named as proxy_url:
https://github.com/googleapis/google-api-ruby-client/blob/8faa43b9f7e6b06cc820df4bcffb384b988e33d1/lib/google/apis/options.rb#L21

This PR align that option name accordingly.

P.S. There is one more PR for that: fog/fog-google#418
but current one can be merged without waiting.

[AlexanderZagaynov]

@tumido @juliancheal please review

[tumido]

Nice one! 👍 Looks great! I love these kinds of fixes.

However I would wait for the fog-google PR to get merged and then update this PR with fog-google version upgrade (so we can be sure the gem is resolved with the fix in place).

[juliancheal]

This PR looks great @AlexanderZagaynov. Although I'm not sure what relation it has the the fog-google PR. Sorry for misunderstanding.

[AlexanderZagaynov]

@juliancheal your previous commit to fog-google was borked by some update
(I've put information in that PR).
Those two PRs together should solve mentioned BZ issue.

[juliancheal]

@AlexanderZagaynov ah that makes sense.

@tumido I thought if we merge this one, at least our code is correct?

[AlexanderZagaynov]

@juliancheal Tom's proposal to wait for fog-google gem update makes sense.

[JPrause]

@miq-bot add_label blocker

[JPrause]

@AlexanderZagaynov if this can be backported, can you add the gaprindashvili/yes label.

[AlexanderZagaynov]

@miq-bot add_label gaprindashvili/yes

[juliancheal]

@miq-bot assign @agrare

[juliancheal]

@agrare are we good to merge?

[juliancheal]

Hi @juliancheal let's wait, as Tom said: #73 (review)

Oh my mistake. I thought we were going ahead with this regardless. I must of imagined that :)

[AlexanderZagaynov]

@tumido @juliancheal fog-google PR was merged, however wasn't released as a version yet.
Gem maintainer (Artem @Temikus) told me that he going to release it in a days, so I just fixed that gem version in our gemspec. We can wait merge till fog-google release, or we can simply point it to github repo, if we're in hurry.

[agrare]

I think we're going to have a problem with moving to the newer fog-google, on master they have spec.add_dependency "fog-core", ">= 2.0", "<= 2.1.0" where on v1.7.1 they just have spec.add_dependency "fog-core".

We're currently using fog-core 1.45 I believe and are in the process of updating other provider gems to support fog-core 2.* but were going to wait until after hammer was branched to merge these.

This would require we pull those back to gaprindashvilli.

Ideally the fog-google maintainer could pull this change to v1.7.2 and leave the gemspec requirements the same.

[AlexanderZagaynov]

@agrare I discussed it with Artem, and he told me, he is going to do that at v2.0 only

[agrare]

Okay awesome thanks @AlexanderZagaynov

[miq-bot]

Checked commits AlexanderZagaynov/manageiq-providers-google@bc7ba98~...7e060d9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[AlexanderZagaynov]

@tumido @juliancheal @agrare done, can merge now

[agrare]

Awesome thanks a lot @Temikus! We're upgrading to newer fog-core in this release but need this fix on older releases. Really appreciate your help.

[agrare]

LGTM

[juliancheal]

Well done on getting it all committed in fog too!

[AlexanderZagaynov]

@miq-bot add_label hammer/yes

[simaishi]

Hammer backport details:

$ git log -1
commit af5dfef52fe510f849844083b0cbb2f9c244738f
Author: Adam Grare <[email protected]>
Date:   Thu Oct 4 09:16:31 2018 -0400

    Merge pull request #73 from AlexanderZagaynov/BZ-1623862_http_proxy
    
    rename client's proxy option
    
    (cherry picked from commit ec11cad1b0d230581173c19f9111fb9613eb1dbe)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1623862

[simaishi]

As per BZ Target Release, removing gaprindashvili/yes