Fix graph issue when deleting node #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix a problem at startup regarding instantiation of objects. See: - #394 (comment) - https://discord.com/channels/729975036148056075/737970741324152882/784180656560275507
ingalless
approved these changes
Dec 9, 2020
jmg-duarte
reviewed
Dec 9, 2020
| @@ -27,7 +27,7 @@ const style = { | |||
| const sizeScale = d3 | |||
| .scaleLinear() | |||
| .domain([0, 30]) | |||
| .range([1, 3]) | |||
| .range([0.5, 2]) | |||
There was a problem hiding this comment.
Nitpick for the future, changes like these add noise to the original PR
I also suffer from this but I think we can all each other get better
jmg-duarte
approved these changes
Dec 9, 2020
jmg-duarte
approved these changes
Dec 9, 2020
AndrewNatoli
reviewed
Dec 9, 2020
| m.selectedNodes = new Set( | ||
| Array.from(m.selectedNodes).filter(nId => remaining.has(nId)) | ||
| ); | ||
|
|
There was a problem hiding this comment.
I rebased my branch for #394 on top of this -- I'm noticing that when I save a file the graph loses track of which node is selected / being hovered over. Could that be related to my change of not deleting the node anymore on save?
There was a problem hiding this comment.
I just reproduced this on master, so it's unrelated to your changes - I am investigating what's causing this
There was a problem hiding this comment.
if you rebase from master the issue is now fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #397, graph freezing when removing a node.
The problem was that the
selectedNodesincluded the deleted graph (if the user deletes it when coming from the document window, which set the selection to the document on focus).Two main changes:
hoverNodeandselectedNodesto make sure they don't include removed notesAlso added a minor style change to the graph for better readibility.
Unfortunately right now it's not easy to add tests for the webview, this would be addressed when making it its own module.