Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph "freezes" when deleting node that links to file that doesn't exist #397

Closed
AndrewNatoli opened this issue Dec 2, 2020 · 1 comment · Fixed by #401
Closed

Graph "freezes" when deleting node that links to file that doesn't exist #397

AndrewNatoli opened this issue Dec 2, 2020 · 1 comment · Fixed by #401
Labels
bug Something isn't working foam-dataviz Related to data visualization
Milestone
0.7.3

Comments

@AndrewNatoli
Copy link
Contributor

  • Foam version: 0.7.2
  • Platform: Mac
  • Issue occur on the foam template repo: Yes

Summary
Scenario that can cause the graph will "freeze" (does not update, can not click / drag, etc)

Steps to reproduce

  1. Create a new note
  2. Add some [[link]]s to notes that exist.
  3. Add a link to [[file-that-does-not-exist]]
  4. Save. File that does not exist should not appear in the footer links (as it does not exist)
  5. Delete your note.
  6. Graph may update but should now be frozen
@AndrewNatoli AndrewNatoli added the bug Something isn't working label Dec 2, 2020
@riccardoferretti riccardoferretti added this to the 0.7.3 milestone Dec 8, 2020
@riccardoferretti riccardoferretti added the foam-dataviz Related to data visualization label Dec 8, 2020
@hikchoi
Copy link

hikchoi commented Dec 9, 2020

I just found this also happens when renaming. I guess it's the same thing as deleting (and then making a new note with a new name).

The graph will freeze before it gets a chance to update with the newly renamed note.

riccardoferretti added a commit that referenced this issue Dec 9, 2020
@riccardoferretti
fix(dataviz): selected nodes must exist after updating graph data (#397)
7f191d0
@riccardoferretti riccardoferretti mentioned this issue Dec 9, 2020
Merged
riccardoferretti added a commit that referenced this issue Dec 9, 2020
@riccardoferretti
Fix graph issue when deleting node (#401)
2135903 
* create commonjs modules

This is to fix a problem at startup regarding instantiation of objects.
See:
- #394 (comment)
- https://discord.com/channels/729975036148056075/737970741324152882/784180656560275507

* minor style tweaks

* fix(dataviz): selected nodes must exist after updating graph data (#397)

* add graph view errors to foam log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working foam-dataviz Related to data visualization
Projects
None yet
Milestone
0.7.3
Development

Successfully merging a pull request may close this issue.

Fix graph issue when deleting node foambubble/foam
3 participants
@riccardoferretti @hikchoi @AndrewNatoli