Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added secret to common template #1871

Merged
merged 9 commits into from
Dec 7, 2021
Merged

Added secret to common template #1871

merged 9 commits into from
Dec 7, 2021

Conversation

yindia
Copy link
Contributor

@yindia yindia commented Nov 29, 2021

Moved flyte-propeller-auth secret template in common template so flytescheduler can use it independently.

Fix: #1870

sbrunk
sbrunk previously approved these changes Nov 30, 2021
Copy link
Member

@sbrunk sbrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia force-pushed the feature/commin-auth-helm branch from 0c7e0b5 to ce35491 Compare December 3, 2021 12:16
@yindia yindia requested a review from EngHabu December 3, 2021 12:42
Signed-off-by: Yuvraj <[email protected]>
Signed-off-by: Yuvraj <[email protected]>
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to need a rebase

EngHabu
EngHabu previously approved these changes Dec 6, 2021
Signed-off-by: Yuvraj <[email protected]>
@yindia yindia merged commit 860a6d8 into master Dec 7, 2021
@yindia yindia deleted the feature/commin-auth-helm branch December 7, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] User common secret in place of flyte-propeller-auth in flyte-core helm chart
4 participants