Remove placeholders in secrets #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeev B <[email protected]>
Signed-off-by: Jeev B <[email protected]>
EngHabu
reviewed
Sep 1, 2021
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
jeevb
commented
Sep 7, 2021
| 2. **flytectl**: A public OAuth2 client that can be used with flytectl command line tool. This client does need a client_secret. | ||
|
|
||
| 3. **flytepropeller**: A client-credentials OAuth2 client that can be used with flytepropeller to talk to flyteAdmin to publish execution events. | ||
| The default secret set to `foobar`. In order for flytepropeller to pickup that secret, you will need to set the secret as follows: |
There was a problem hiding this comment.
Should this default value be specified? This PR removes foobar as a default.
There was a problem hiding this comment.
|
@jeevb should this be merged? |
|
@EngHabu suggested that we walk through the process manually one time to make sure all the docs are complete. Unfortunately, I don't have time to follow-up on that right now. |
|
@EngHabu: Any update on this? |
|
This PR is adding moving the secret out and making it configurable in values file as we discussed at some point... Do you mind trimming this PR down to just the kustomize changes and docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jeev B [email protected]