This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Add warning comments to all YAML-modifying regular expressions #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be sufficient to ensure that anyone considering modifying these bits of code understands it's probably not a good idea.
squaremo
approved these changes
Mar 22, 2018
| // Replacing labels: these are in two places, the container template and the selector | ||
| // TODO: This doesn't handle # comments | ||
| // TODO: This encodes an expectation of map keys being ordered (i.e. name *then* version) | ||
| // TODO: This assumes that these are indented by exactly 2 spaces (which may not be true) | ||
| replaceLabelsRE := multilineRE( | ||
| `((?: selector| labels):.*)`, | ||
| `((?: ){2,4}name:.*)`, | ||
| `((?: ){2,4}version:\s*) (?:` + optq + `[-\w]+` + optq + `)(\s.*)`, | ||
| `((?: ){2,4}version:\s*) (?:`+optq+`[-\w]+`+optq+`)(\s.*)`, |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be sufficient to ensure that anyone considering modifying these bits
of code understands it's probably not a good idea.
See #1019