You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
We have the requirement that modifying yaml belonging to the user must preserve their comments, since the output may still be read by humans. There is no existing library for Go which supports this behaviour, and as a result we manipulate yaml with a collection of regular expressions in cluster/kubernetes/update.go and cluster/kubernetes/policies.go.
This code is difficult to maintain, changes to it are difficult to review, and it's difficult to be sure it does the right thing for all possible inputs.
We should delete it all and offload the yaml-modification to kubeyaml, as is being done in #976.
The text was updated successfully, but these errors were encountered:
We have the requirement that modifying yaml belonging to the user must preserve their comments, since the output may still be read by humans. There is no existing library for Go which supports this behaviour, and as a result we manipulate yaml with a collection of regular expressions in
cluster/kubernetes/update.go
andcluster/kubernetes/policies.go
.This code is difficult to maintain, changes to it are difficult to review, and it's difficult to be sure it does the right thing for all possible inputs.
We should delete it all and offload the yaml-modification to
kubeyaml
, as is being done in #976.The text was updated successfully, but these errors were encountered: