Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Delete all yaml-modifying code #1019

Closed
samb1729 opened this issue Mar 22, 2018 · 5 comments
Closed

Delete all yaml-modifying code #1019

samb1729 opened this issue Mar 22, 2018 · 5 comments

Comments

@samb1729
Copy link
Contributor

We have the requirement that modifying yaml belonging to the user must preserve their comments, since the output may still be read by humans. There is no existing library for Go which supports this behaviour, and as a result we manipulate yaml with a collection of regular expressions in cluster/kubernetes/update.go and cluster/kubernetes/policies.go.

This code is difficult to maintain, changes to it are difficult to review, and it's difficult to be sure it does the right thing for all possible inputs.

We should delete it all and offload the yaml-modification to kubeyaml, as is being done in #976.

@squaremo
Copy link
Member

squaremo commented Jun 5, 2018

As of #976 being merged, we don't modify YAMLs from the go code any more.

@squaremo squaremo closed this as completed Jun 5, 2018
@samb1729
Copy link
Contributor Author

samb1729 commented Jun 5, 2018

Awesome!

@squaremo
Copy link
Member

squaremo commented Jun 5, 2018

For the record: #1120

@samb1729
Copy link
Contributor Author

samb1729 commented Jun 5, 2018

No help wanted labels in sight

@squaremo
Copy link
Member

squaremo commented Jun 5, 2018

No help wanted labels in sight

Magic labeling machine waved!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants