Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Allow saving photos picked with PHPicker without permissions #6429

Merged

Conversation

PiotrMitkowski
Copy link
Contributor

@PiotrMitkowski PiotrMitkowski commented Sep 15, 2022

Description

Bugfix for picking (multi) images with PHPicker without gallery permissions.

While the current version allows accessing the gallery without permissions, it was still requiring them for returning picked images as a result.

Related issues

flutter/flutter#65995
Bug reported in comment under #5915

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@PiotrMitkowski PiotrMitkowski marked this pull request as ready for review September 15, 2022 07:36
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this! The code looks good, but the bug you are fixing needs test coverage (i.e., a test that would fail without the logic change).

PiotrMitkowski and others added 2 commits September 19, 2022 08:23
@PiotrMitkowski PiotrMitkowski requested review from jmagman and stuartmorgan and removed request for cyanglaz and jmagman September 19, 2022 07:30
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 19, 2022
@auto-submit auto-submit bot merged commit 2cbb314 into flutter:main Sep 19, 2022
@PiotrMitkowski PiotrMitkowski deleted the ios-optional-permissions-bugfix branch September 20, 2022 06:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 20, 2022
@liumengchun
Copy link

Hello, have you fixed the problem of 'Select More Photos'? I have also reproduced the problem here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: image_picker platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants