[image_picker] add requestFullMetadata for iOS (optional permissions) #5915

PiotrMitkowski · 2022-06-06T10:15:02Z

Description

Originally #3264 made by @cpboyd
Creating a new PR as I've closed the previous one (#4638) by a mistake

Make iOS 11+ permissions requests optional per https://developer.apple.com/forums/thread/653414.
PHAssets aren't actually required and there was already some fallback code in place.

Related issues

Fixes flutter/flutter#65995

Pre-launch Checklist

Updated changelog with description of latest changes

…ch actual changes

…-permissions � Conflicts: � packages/image_picker/image_picker_platform_interface/CHANGELOG.md � packages/image_picker/image_picker_platform_interface/pubspec.yaml

Added missing native implementation of the new flag

…os-optional-permissions

…ermissions � Conflicts: � packages/image_picker/image_picker/CHANGELOG.md � packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m � packages/image_picker/image_picker/pubspec.yaml

…ermissions � Conflicts: � packages/image_picker/image_picker/CHANGELOG.md � packages/image_picker/image_picker_platform_interface/CHANGELOG.md � packages/image_picker/image_picker_platform_interface/pubspec.yaml

Fixed failing test

…ermissions

idish · 2022-09-14T08:17:35Z

Hey, I've just checked out this PR in my app (both on Simulator and real device).
Seems as _picker.pickMultiImage(requestFullMetadata: false);
is crashing after picking photos with the following error:

This app has crashed because it attempted to access privacy-sensitive data without a usage description.  The app's Info.plist must contain an NSPhotoLibraryUsageDescription key with a string value explaining to the user how the app uses this data.

This most probably an issue that resides within the new image_picker_ios (0.8.6) version, and not this PR directly, but still it worth mentioning it here before merging.
Did anyone else have tested this code in a real environment?

PiotrMitkowski · 2022-09-14T12:25:56Z

@idish thanks for your feedback! I'll take an extra look to make sure, that it works correctly.

PiotrMitkowski · 2022-09-15T06:39:47Z

@idish I've found a bug and fixed it in #6429. You can take a look there, if you want. I'll put this PR in draft while waiting on the other one to be merged.

idish · 2022-09-18T10:57:20Z

@idish I've found a bug and fixed it in #6429. You can take a look there, if you want. I'll put this PR in draft while waiting on the other one to be merged.

Thanks! I can confirm that your bugfix PR works.

…ermissions

stuartmorgan

Looks great! It just needs the final version update for your bugfix and it should be good to go! Thanks again for all the work on this.

@cyanglaz Can you do the secondary sign-off?

stuartmorgan · 2022-09-20T15:13:49Z

packages/image_picker/image_picker/pubspec.yaml

@@ -24,8 +24,8 @@ dependencies:
    sdk: flutter
  image_picker_android: ^0.8.4+11
  image_picker_for_web: ^2.1.0
-  image_picker_ios: ^0.8.4+11
-  image_picker_platform_interface: ^2.3.0
+  image_picker_ios: ^0.8.6


This should be 0.8.6+1 now to pick up the last fix.

I'm still waiting for this version to be published on pub.dev. It seems that the release action failed. Could you take a look? https://github.com/flutter/plugins/actions/runs/3084943502

Oops, sorry about that; I forgot to check that publishing had completed. It looks like there was a flake in the analysis run during post-submit tests, and it's already being re-run.

Now it's live. Sorry for the delay!

Should be good to go now, thanks!

…ermissions

stuartmorgan · 2022-09-29T20:24:49Z

@cyanglaz Ping from triage on this review.

cyanglaz

LGTM.

…rmissions) (flutter/plugins#5915)

liumengchun · 2022-10-21T07:35:45Z

Hello, have you fixed the problem of 'Select More Photos'? I have also reproduced the problem here

PiotrMitkowski · 2022-10-21T08:47:30Z

@liumengchun this is more like a workaround to not use the gallery permissions at all. They are needed only to access some specific image metadata, which isn't needed in most of the cases.

furaiev · 2022-10-21T15:05:12Z

@PiotrMitkowski thank you, great work 👏

…flutter#5915)

… - platform interface changes for multi image picking (flutter#5914) Platform interface changes for flutter#5915 - adding possibility to disable full metadata when picking multiple images

…flutter#5915)

PiotrMitkowski added 30 commits January 3, 2022 13:55

Added new image picking method with flag for controlling metadata

5d3a9aa

Updated tests with cases for the new method

4195dca

Updated changelog with description of latest changes

Updated changelog in platform interface and app-facing package to mat…

7d255de

…ch actual changes

Updated app-facing package to call new method from platform interface

3fd7383

Merge branch 'master' of github.com:flutter/plugins into ios-optional…

686bc22

…-permissions � Conflicts: � packages/image_picker/image_picker_platform_interface/CHANGELOG.md � packages/image_picker/image_picker_platform_interface/pubspec.yaml

Fixed version in changelog file

1f73191

Merge branch 'main' into ios-optional-permissions

24d0679

Merge branch 'main' into ios-optional-permissions

1ba0c73

PR remarks

1084763

Added missing native implementation of the new flag

Renamed flag to better specify its purpose

a89ad0a

Renamed flag in remaining occurences

8ff7492

Merge branch 'main' into ios-optional-permissions

193bbe9

Fixed formatting and originalAsset assignment

95eef20

Merge remote-tracking branch 'origin/ios-optional-permissions' into i…

e10b24e

…os-optional-permissions

Resolved merge conflicts

f2c2e68

PR remarks

f5f94b2

Fixed issues after merge

bd3dfeb

Added a test for picking image without full metadata

b99ba07

Fixed code formatting

3d6c45c

PR remarks

bf3f55c

Fixed linter warnings

742b259

Added dependency overrides for missing modules

d41b390

Fixed failing test

Fixed formatting

ead2f62

Added options class for handling image picking settings

7b6ace9

Added missing license comment

0f43653

Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…

c6dcc49

…ermissions

Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…

9ba71b9

…ermissions

PR remarks

c1fc9da

PiotrMitkowski marked this pull request as draft September 15, 2022 06:39

PiotrMitkowski mentioned this pull request Sep 15, 2022

[image_picker] Allow saving photos picked with PHPicker without permissions #6429

Merged

11 tasks

Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…

58d6b10

…ermissions

stuartmorgan suggested changes Sep 20, 2022

View reviewed changes

PiotrMitkowski added 2 commits September 21, 2022 08:30

Merge branch 'main' of github.com:flutter/plugins into ios-optional-p…

f80f09d

…ermissions

Updated package with iOS implementation to fix a bug

39e8d37

PiotrMitkowski marked this pull request as ready for review September 21, 2022 07:09

PiotrMitkowski requested a review from stuartmorgan September 21, 2022 07:09

stuartmorgan approved these changes Sep 21, 2022

View reviewed changes

stuartmorgan requested a review from cyanglaz September 21, 2022 13:56

furaiev mentioned this pull request Oct 4, 2022

[image_picker] choosing Select Photos permission shows all photos flutter/flutter#65995

Closed

cyanglaz approved these changes Oct 5, 2022

View reviewed changes

cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 5, 2022

auto-submit bot merged commit fb5c86c into flutter:main Oct 5, 2022

engine-flutter-autoroll mentioned this pull request Oct 6, 2022

Roll Plugins from 3a928b8a3d8b to 54e748c343ef (3 revisions) flutter/flutter#113030

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 6, 2022

fb5c86c95 [image_picker] add requestFullMetadata for iOS (optional pe…

948f659

…rmissions) (flutter/plugins#5915)

jmagman mentioned this pull request Oct 18, 2022

[image_picker] NSPhotoLibraryUsageDescription is still required if uploading to the App Store flutter/flutter#113603

Closed

PiotrMitkowski deleted the ios-optional-permissions branch October 21, 2022 08:45

adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022

[image_picker] add requestFullMetadata for iOS (optional permissions) (…

969ea51

…flutter#5915)

mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023

[image_picker] add requestFullMetadata for iOS (optional permissions) (…

9109745

…flutter#5915)

OlehMarch mentioned this pull request Feb 11, 2025

File Picker Ignores iOS Photo Access Limitations miguelpruivo/flutter_file_picker#1439

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker] add requestFullMetadata for iOS (optional permissions) #5915

[image_picker] add requestFullMetadata for iOS (optional permissions) #5915

PiotrMitkowski commented Jun 6, 2022 •

edited

Loading

idish commented Sep 14, 2022 •

edited

Loading

PiotrMitkowski commented Sep 14, 2022

PiotrMitkowski commented Sep 15, 2022

idish commented Sep 18, 2022

stuartmorgan left a comment

stuartmorgan Sep 20, 2022

PiotrMitkowski Sep 20, 2022 •

edited

Loading

stuartmorgan Sep 20, 2022

stuartmorgan Sep 20, 2022

PiotrMitkowski Sep 21, 2022

stuartmorgan commented Sep 29, 2022

cyanglaz left a comment

liumengchun commented Oct 21, 2022

PiotrMitkowski commented Oct 21, 2022

furaiev commented Oct 21, 2022

[image_picker] add requestFullMetadata for iOS (optional permissions) #5915

[image_picker] add requestFullMetadata for iOS (optional permissions) #5915

Conversation

PiotrMitkowski commented Jun 6, 2022 • edited Loading

Description

Related issues

Pre-launch Checklist

idish commented Sep 14, 2022 • edited Loading

PiotrMitkowski commented Sep 14, 2022

PiotrMitkowski commented Sep 15, 2022

idish commented Sep 18, 2022

stuartmorgan left a comment

Choose a reason for hiding this comment

stuartmorgan Sep 20, 2022

Choose a reason for hiding this comment

PiotrMitkowski Sep 20, 2022 • edited Loading

Choose a reason for hiding this comment

stuartmorgan Sep 20, 2022

Choose a reason for hiding this comment

stuartmorgan Sep 20, 2022

Choose a reason for hiding this comment

PiotrMitkowski Sep 21, 2022

Choose a reason for hiding this comment

stuartmorgan commented Sep 29, 2022

cyanglaz left a comment

Choose a reason for hiding this comment

liumengchun commented Oct 21, 2022

PiotrMitkowski commented Oct 21, 2022

furaiev commented Oct 21, 2022

PiotrMitkowski commented Jun 6, 2022 •

edited

Loading

idish commented Sep 14, 2022 •

edited

Loading

PiotrMitkowski Sep 20, 2022 •

edited

Loading