This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[CP-beta][Android] post image task to main handler. #52166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutteractionsbot
added
the
cp: review
|
@jonahwilliams please fill out the PR description above, afterwards the release team will review this request. |
johnmccutchan
approved these changes
Apr 18, 2024
godofredoc
added
the
autosubmit
auto-submit
bot
merged commit 1deeac8
into
flutter:flutter-3.22-candidate.0
25 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
Test failures in Impeller migration PR: flutter/packages#6461
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Ensure that Android platform view updates are posted on correct thread when platform view is created on background handler.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Migration to Impeller plugin APIs is blocked.
Workaround:
Is there a workaround for this issue?
Disable impeller
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
However the tests are in flutter/packages and not flutter/engine.
Validation Steps:
What are the steps to validate that this fix works?
Run the unit tests on the linked PR in flutter/packages