This repository has been archived by the owner on Feb 25, 2025. It is now read-only.
[Android] post image task to main handler. #52025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
approved these changes
Apr 10, 2024
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/52025, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 10, 2024
…146605) flutter/engine@beee02b...91ba235 2024-04-10 [email protected] Adds iOS builds to local_engine.json (flutter/engine#52027) 2024-04-10 [email protected] Roll Skia from df6d08abb447 to 91e0c0f4bf41 (3 revisions) (flutter/engine#52026) 2024-04-10 [email protected] [Android] post image task to main handler. (flutter/engine#52025) 2024-04-10 [email protected] [et] Adds --lto flag to build. Plumbs verbose flag differently. (flutter/engine#52021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jonahwilliams
added
the
cp: beta
flutteractionsbot
pushed a commit
to flutteractionsbot/engine
that referenced
this pull request
Apr 16, 2024
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…lutter#146605) flutter/engine@beee02b...91ba235 2024-04-10 [email protected] Adds iOS builds to local_engine.json (flutter/engine#52027) 2024-04-10 [email protected] Roll Skia from df6d08abb447 to 91e0c0f4bf41 (3 revisions) (flutter/engine#52026) 2024-04-10 [email protected] [Android] post image task to main handler. (flutter/engine#52025) 2024-04-10 [email protected] [et] Adds --lto flag to build. Plumbs verbose flag differently. (flutter/engine#52021) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#146465
This callback needs to run on the platform main thread. Since it was just constructing a handler, that would callback from whatever thread it was created from. Update this to specifically create a main thread handler.