Remove usage of SkToBool #38401
Remove usage of SkToBool #38401
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 38401, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead. |
|
auto label is removed for flutter/engine, pr: 38401, due to Validations Fail. |
zanderso
added
the
autosubmit
…117336) * 290f3efc2 Add more missing includes (flutter/engine#38398) * 24a6a9183 Remove usage of SkToBool (flutter/engine#38401) * 725d47da2 reland: Started using FlutterEngineGroups by default on Android (flutter/engine#38367) * c7cc1b6f7 [Impeller Scene] Add animation/PBR descriptions to ipscene (flutter/engine#38397) * cba3a3990 Roll Skia from 46af4ad25426 to 8876daf17554 (3 revisions) (flutter/engine#38404)
Client Changes: - https://crrev.com/c/4116590 - flutter/engine#38401 Change-Id: I5ee9d7fd063f7c7a49e53a49a74245412a208824 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/620656 Reviewed-by: Brian Osman <[email protected]>
…lutter#117336) * 290f3efc2 Add more missing includes (flutter/engine#38398) * 24a6a9183 Remove usage of SkToBool (flutter/engine#38401) * 725d47da2 reland: Started using FlutterEngineGroups by default on Android (flutter/engine#38367) * c7cc1b6f7 [Impeller Scene] Add animation/PBR descriptions to ipscene (flutter/engine#38397) * cba3a3990 Roll Skia from 46af4ad25426 to 8876daf17554 (3 revisions) (flutter/engine#38404)
Skia plans to remove this from the public API.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.