reland: Started using FlutterEngineGroups by default on Android #38367
Conversation
…id (flutter#37822)" (flutter#38351)" This reverts commit 13ae6eb.
This comment was marked as outdated.
This comment was marked as outdated.
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
gaaclarke
force-pushed
the
revert-13ae6eb75ab97947b2bcd507bf45ee33a1d2033d
branch
from
8a7bf16 to
3e5e7a4
Compare
gaaclarke
changed the title
shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java
Outdated
Show resolved
Hide resolved
shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java
Outdated
Show resolved
Hide resolved
gaaclarke
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 38367, Failed to merge pr#: 38367 with Pull request could not be merged: Resource not accessible by integration. |
|
@gaaclarke Did you or someone else re-run the check that tripped on "Resource not accessible by integration". I'm chasing down the flake and just want to make sure it didn't automagically resolve itself. |
@chinmaygarde wasn't me. I didn't even see it. I pushed up a handful of commits back-to-back, so maybe you saw it in between the pushes? |
|
Oh wait, i see the message about autosubmit failing. Weird, I don't know what happened. |
|
Okie dokie. Pushing the commits was probably what caused the re-runs. Anyway, I have the reference. |
…117336) * 290f3efc2 Add more missing includes (flutter/engine#38398) * 24a6a9183 Remove usage of SkToBool (flutter/engine#38401) * 725d47da2 reland: Started using FlutterEngineGroups by default on Android (flutter/engine#38367) * c7cc1b6f7 [Impeller Scene] Add animation/PBR descriptions to ipscene (flutter/engine#38397) * cba3a3990 Roll Skia from 46af4ad25426 to 8876daf17554 (3 revisions) (flutter/engine#38404)
…ter#38367) * Revert "Revert "Started using FlutterEngineGroups by default on Android (flutter#37822)" (flutter#38351)" This reverts commit 13ae6eb. * fixed the entrypoint test * updated old test * coldpalelight's suggestion * added entrypoint args
…lutter#117336) * 290f3efc2 Add more missing includes (flutter/engine#38398) * 24a6a9183 Remove usage of SkToBool (flutter/engine#38401) * 725d47da2 reland: Started using FlutterEngineGroups by default on Android (flutter/engine#38367) * c7cc1b6f7 [Impeller Scene] Add animation/PBR descriptions to ipscene (flutter/engine#38397) * cba3a3990 Roll Skia from 46af4ad25426 to 8876daf17554 (3 revisions) (flutter/engine#38404)
relands: #37822
revert pr: #38351
The fix is in a separate commit in the PR. I just factored out some logic for creating engines from groups from elsewhere that takes into account the entrypoint. It's a bit tricky since it isn't clear how the engine was getting those things.
There already is a test that covers this.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.