Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transitive includes in libcpp #660

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

knopp
Copy link
Member

@knopp knopp commented Dec 16, 2022

This should make it easier to spot missing includes causing problems on internal builds such has flutter/engine#38332.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@knopp knopp changed the title Remove transitive includes in libcc Remove transitive includes in libcpp Dec 16, 2022
@knopp knopp force-pushed the libcpp_remove_transitive_includes branch from d478ada to 8ed59b4 Compare December 16, 2022 13:20
@knopp knopp requested a review from cbracken December 16, 2022 13:22
@cbracken
Copy link
Member

cbracken commented Dec 17, 2022

@chinmaygarde Looks like the the overlaid __config_site file was added in #588. Are we manually rolling from an upstream source? If so, we probably want to avoid patching it here in order to avoid it getting stomped on the next roll. Maybe cleaner to add the define in a globally used config in GN instead.

The intent here is to get our config closer to the google3 config. We recently had an internal-only breakage b/262764490 (fix) due to a missing #include <vector> that was transitively included.

Would be nice to eventually add iwyu to the lint, but this at least covers libcxx includes.

@cbracken
Copy link
Member

/cc @jason-simmons as well, who's familiar with our process for rolling our libcxx.

@jason-simmons
Copy link
Member

__config_site is part of Flutter's buildroot and is not copied from any upstream source. It contains customized flags for configuring Flutter's use of libcxx.

@knopp knopp merged commit c914b6f into flutter:master Jan 2, 2023
@knopp knopp deleted the libcpp_remove_transitive_includes branch January 2, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants