Update to a current version of libcxx and libcxxabi #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jul 12, 2022
|
I believe this is good to go. Filed flutter/flutter#107492 to track updating the min deployment target. |
8 tasks
jmagman
reviewed
Jul 15, 2022
build/config/mac/mac_sdk.gni
Outdated
| @@ -10,7 +10,7 @@ declare_args() { | |||
|
|
|||
| # The MACOSX_DEPLOYMENT_TARGET variable used when compiling. | |||
| # Must be of the form x.x.x for Info.plist files. | |||
| mac_deployment_target = "10.11.0" | |||
| mac_deployment_target = "10.12.0" | |||
There was a problem hiding this comment.
Can you change this to 10.13? See flutter/flutter#107492 (comment)
There was a problem hiding this comment.
Should mac_sdk_min also be bumped to 10.13?
There was a problem hiding this comment.
I guess it should if everything happily compiles...
There was a problem hiding this comment.
Updated mac_sdk_min to 10.13 and confirmed that the engine builds and runs
jmagman
requested changes
Jul 15, 2022
jason-simmons
force-pushed
the
libcxx_update_070822
branch
from
a331a4b to
de30581
Compare
This also updates the engine's minimum required version of macOS to 10.13
jason-simmons
force-pushed
the
libcxx_update_070822
branch
from
de30581 to
dca5607
Compare
This was referenced Jul 26, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates the engine's minimum required version of macOS to 10.13