Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to log level #715

Merged
merged 1 commit into from
Nov 27, 2015

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Nov 27, 2015

We can see this via --show-plugin-config after merge #706

We can see this via `--show-plugin-config` after merge fluent#706
@sonots
Copy link
Member

sonots commented Nov 27, 2015

👍

@@ -343,6 +343,7 @@ def enable_color(b = true)
module PluginLoggerMixin
def self.included(klass)
klass.instance_eval {
desc 'Allows the user to set different levels of logging for each plugin.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows to set is fine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is using the same wording with docs. Let me merge although I don't know who is "the" user.

sonots added a commit that referenced this pull request Nov 27, 2015
@sonots sonots merged commit fb352ba into fluent:master Nov 27, 2015
@okkez okkez deleted the add-description-to-log-level branch December 2, 2015 02:06
sonots added a commit that referenced this pull request Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants