Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show plugin config ancestors #706

Merged
merged 6 commits into from
Dec 3, 2015

Conversation

okkez
Copy link
Contributor

@okkez okkez commented Nov 20, 2015

No description provided.

In previous version, we cannot see complete plugin configuration.  In
this version, we can see complete plugin configuration.
@okkez
Copy link
Contributor Author

okkez commented Nov 20, 2015

For example

$ bundle exec fluentd --show-plugin-config input:tcp
2015-11-20 11:43:57 +0900 [info]: Show config for input:tcp
2015-11-20 11:43:57 +0900 [info]: 
Fluent::Input
 log_level: string: <nil>
Fluent::SocketUtil::BaseInput
 tag: string: <nil>
 format: string: <nil>
 port: integer: <5150>
 bind: string: <"0.0.0.0">
 source_host_key: string: <nil>
 blocking_timeout: time: <0.5>
Fluent::TcpInput
 delimiter: string: <"\n">

@repeatedly
Copy link
Member

In some cases, Fluent::SocketUtil::BaseInput like information is not needed because users don't know its implementation detail.
So by default, hiding such implementation is better.

@okkez
Copy link
Contributor Author

okkez commented Nov 23, 2015

I've changed dumped plugin config appearance.

$ bundle exec fluentd --show-plugin-config=input:tcp
2015-11-24 08:38:32 +0900 [info]: Show config for input:tcp
2015-11-24 08:38:32 +0900 [info]: 
log_level: string: <nil>
tag: string: <nil>
format: string: <nil>
port: integer: <5150>
bind: string: <"0.0.0.0">
source_host_key: string: <nil>
blocking_timeout: time: <0.5>
delimiter: string: <"\n">

$ bundle exec fluentd --show-plugin-config=input:tcp -v
2015-11-24 08:38:39 +0900 [info]: fluent/supervisor.rb:212:show_plugin_config: Show config for input:tcp
2015-11-24 08:38:39 +0900 [info]: fluent/supervisor.rb:227:show_plugin_config: 
Fluent::Input
 log_level: string: <nil>
Fluent::SocketUtil::BaseInput
 tag: string: <nil>
 format: string: <nil>
 port: integer: <5150>
 bind: string: <"0.0.0.0">
 source_host_key: string: <nil>
 blocking_timeout: time: <0.5>
Fluent::TcpInput
 delimiter: string: <"\n">

@repeatedly
Copy link
Member

How about trace level?
Some users use debug level on testing.
trace is useful for developers.

@okkez
Copy link
Contributor Author

okkez commented Nov 26, 2015

I think debug is enough to hide verbose output because --show-plugin-config have no effect while running fluentd.

okkez added a commit to okkez/fluentd that referenced this pull request Nov 27, 2015
We can see this via `--show-plugin-config` after merge fluent#706
repeatedly added a commit that referenced this pull request Dec 3, 2015
@repeatedly repeatedly merged commit 4d5989e into fluent:master Dec 3, 2015
@okkez okkez deleted the show-plugin-config-ancestors branch December 3, 2015 23:54
repeatedly added a commit that referenced this pull request Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants