Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk/go): ensure empty string cannot be passed as path parameters #3722

Merged
merged 7 commits into from
Dec 16, 2024
Merged

fix(sdk/go): ensure empty string cannot be passed as path parameters #3722

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ce307de
fix(sdk/go): ensure empty string cannot be passed as path parameters
GeorgeMac Dec 13, 2024
f8109dc
fix(build): dont ensure http supports empty namespace in client
GeorgeMac Dec 13, 2024
b213f4d
feat(cmd/protoc): add path default protobuf option
GeorgeMac Dec 16, 2024
49c5fb2
chore(build): remove guard against empty namespace
GeorgeMac Dec 16, 2024
ca43831
chore(cmd/protoc): remove debug log line
GeorgeMac Dec 16, 2024
a5d2748
chore: go work sync
GeorgeMac Dec 16, 2024
6962272
chore(build): remove now unnecessary setting of namespace default in …
GeorgeMac Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(build): remove now unnecessary setting of namespace default in … 
…test
  • Loading branch information
@GeorgeMac
GeorgeMac committed Dec 16, 2024
commit 69622724abe627df00e979065f1e0c0b8d488a62
3 changes: 0 additions & 3 deletions build/testing/integration/authz/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,6 @@ func (s clientCallSet) assert(t *testing.T, ctx context.Context, client sdk.SDK)
type clientCall func(*testing.T, context.Context, sdk.SDK) error

func GetNamespace(in *flipt.GetNamespaceRequest) clientCall {
if in.GetNamespaceKey() == "" {
in.Key = "default"
}
return func(t *testing.T, ctx context.Context, s sdk.SDK) error {
_, err := s.Flipt().GetNamespace(ctx, in)
return fmt.Errorf("GetNamespace: %w", err)
Expand Down
Loading