fix(sdk/go): ensure empty string cannot be passed as path parameters #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
approved these changes
Dec 13, 2024
|
I expect this will fail. We may need to merge after @erka original PR / update more code paths. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3722 +/- ##
==========================================
+ Coverage 64.51% 64.55% +0.03%
==========================================
Files 170 170
Lines 17163 17163
==========================================
+ Hits 11073 11079 +6
+ Misses 5397 5393 -4
+ Partials 693 691 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Bare with me while I fix these tests |
|
I just pushed an update to this which takes a different approach. TL;DR exploring setting path defaults as protobuf options. |
GeorgeMac
force-pushed
the
gm/sdk-http-validate-empty
branch
from
f612fa1 to
a5d2748
Compare
GeorgeMac
commented
Dec 16, 2024
Comment on lines
+89
to
+91
| if v.Key == "" { | ||
| v.Key = "default" | ||
| } |
There was a problem hiding this comment.
See here for example output for new option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #3716
@erka spotted that empty string can be passed to
GetNamespaceswhich leads to the HTTP client making a list namespaces operation when the key is empty. This is due to the fact we strip slash on our paths.This updates the SDK generator to support a new protobuf method option
flipt.options.flipt_client.This option includes the ability to define path defaults (strings only currently).
When a default is found in the HTTP client generation, it is set to the default if the path parameter is the zero value ("").