Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Text direction for RTL languages #441

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

uomar8
Copy link
Contributor

@uomar8 uomar8 commented Feb 17, 2024

Update ResultViewContent.kt

add textDirection = TextDirection.Content to al textview

@firemaples firemaples changed the base branch from master to refactor/v4.0.0 March 20, 2024 07:23
add textDirection = TextDirection.Content
@firemaples firemaples linked an issue Mar 20, 2024 that may be closed by this pull request
@firemaples
Copy link
Owner

firemaples commented Mar 20, 2024

Thank you for the investigation and provide the fix. 🙇‍♂️

I updated your code with LocalTextStyle to make all the texts have this setting

Preview

Two examples from #439 (comment)

Example 1 Example 2

@firemaples firemaples changed the title fix Text direction for RTL languages Fix Text direction for RTL languages Mar 20, 2024
@firemaples firemaples merged commit 6af8179 into firemaples:refactor/v4.0.0 Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text direction is wrong (RTL languages)
2 participants